The Git clone of Drupal core in setup_local_dev.sh takes too long. Change it to a shallow clone.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

TravisCarden created an issue. See original summary.

traviscarden’s picture

Assigned: traviscarden » Unassigned
Status: Active » Needs review
traviscarden’s picture

phenaproxima’s picture

Status: Needs review » Needs work

From what I understand, a shallow clone will remove the ability to do git bisect on Drupal core.

That can be a problem, since there have been instances before when an upstream change in core broke us, and we needed to bisect core to track it down.

I support changing to a shallow clone by default, but I'd like to see the following:

  • We should document that this is a shallow clone, and the effect on git bisect (commit blocker)
  • We should be able to override this behavior with an environment variable or something (commit blocker if it's easy, otherwise let's do this in a follow-up)
  • If this is even possible, we should document how to convert the shallow clone to a deep clone (very nice to have)
traviscarden’s picture

Status: Needs work » Needs review

You are correct, @phenaproxima. I have implemented all three of your suggestions.

phenaproxima’s picture

Issue tags: +Needs manual testing

Code and documentation look good to me. I don't have time to manually test it, so if @rahul_ could take that on (run the script, confirm it's fast, then make sure you can convert it to a deep clone using the commands in DEVELOPING.md), I think this is RTBC from me.

traviscarden’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Marking RTBC per @phenaproxima and @rahul_ 's feedback in Slack.

phenaproxima’s picture

phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Merged into 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.