Per #2966864: Add optional support for CKEditor 5 in D9 so we can remove CKE 4 from Drupal 10, CKEditor 5 has been added to Drupal core in #3231364: Add CKEditor 5 module to Drupal core, is being stabilized in #3238333: Roadmap to CKEditor 5 stable in Drupal 9, is being deprecated in #3270437: [meta] Tasks to deprecate the CKEditor 4 module and will be removed in Drupal 10.
This issue is to coordinate and track the steps needed to remove CKEditor (4) after it is deprecated. See Remove a core module and move it to a contributed project of the deprecation policy.
Do the work necessary to remove CKEditor (4) from core.
core/modules/ckeditor from the 9.5.x branch into the contrib Git repo at https://www.drupal.org/project/ckeditor.project_composer step is Fixed, update the documentation with the new composer command.No more CKEditor (4).
TBD, possibly in child issues
TBD, possible in child issues
Needed.
Comments
Comment #2
wim leersHm …
are present in #3274155: [Meta] Tasks to remove Quick Edit from core and move to contrib so I copied them over here, but are they still necessary after #3292380: Remove the "replace" section from core/composer.json?
Comment #3
wim leersComment #4
wim leers#3306630: Split the core 9.5.x ckeditor history into a new 1.0.x branch and cut a 1.0.0 release needs review, in particular #3306630-20: Split the core 9.5.x ckeditor history into a new 1.0.x branch and cut a 1.0.0 release wrt the
core/ckeditorasset library.Tests are passing for the https://www.drupal.org/project/ckeditor module against both 9.5 and 10.0: https://www.drupal.org/node/606034/qa
Comment #5
wim leersℹ️ I'm working on having a green MR at #3270438: Remove CKEditor 4 from core to help us get 99% of the way there while we wait for #3306630: Split the core 9.5.x ckeditor history into a new 1.0.x branch and cut a 1.0.0 release to be sorted out.
Comment #6
wim leersFiled #3308347: Ensure that ckeditor does not get special core treatment.
Comment #7
wim leersComment #8
wim leersOops, I should've used #3274182: [Meta] Tasks to remove CKEditor 4 from core and move to contrib and not created this issue … well, moved relevant issue tags over 👍
Comment #9
wim leersPer @catch in #3270438-47: Remove CKEditor 4 from core, we're now just waiting for the Drupal Security Team to respond at #3306909: Get Drupal Security Team approval to commit vendor/ckeditor.js to the drupal/ckeditor project, then the removal commit will happen.
Comment #10
wim leers🚢 https://www.drupal.org/project/ckeditor/releases/1.0.0 🚢
This means #3270438: Remove CKEditor 4 from core is unblocked 👍
Comment #11
wim leers#3270438: Remove CKEditor 4 from core landed!
Comment #12
wim leersMarking to signal that no further work here is necessary for
10.0.0-beta1to be tagged — all remaining work lies in moving issues to the contrib module, moving docs on d.o and waiting for the Drupal Association to finish the composer facade changes.Comment #13
wim leers@quietone has started doing the bulk move! 🤩 Thank you!!! 🙏
Comment #14
wim leers@quietone finished it! 🙏🥳
Comment #15
wim leersRetitled https://www.drupal.org/docs/7/modules/ckeditor/overview and https://www.drupal.org/docs/7/modules/ckeditor/drupal-7-ckeditor-vs-cked... to make it clear in the title & menu that they're for the D7 contrib module.
I intended to move https://www.drupal.org/docs/8/core/modules/ckeditor into https://www.drupal.org/docs/7/modules/ckeditor. But could not figure out how. I then tried moving all child pages, but … there too I could not figure out how. I do not seem to be able to (or allowed to) move for example https://www.drupal.org/docs/8/core/modules/ckeditor/overview out of https://www.drupal.org/docs/8/core/modules/ckeditor and into https://www.drupal.org/docs/7/modules/ckeditor 🤷
Comment #16
wim leers#3308347: Ensure that ckeditor does not get special core treatment was completed! https://www.drupal.org/project/ckeditor/releases/1.0.1 is out now to fix 9.4 compatibility — see #3309065: Compatibility with Drupal 9.4 😬
Comment #17
quietone commentedHowever, there is EXPERIMENTAL: CKEditor 5 in core modules. It is not in the menu and It has two pages.
The first doesn't appear to be relevant anymore. What about the second? Is anything there useful?
Comment #18
wim leers#17: correct, the first can be archived, the second is still relevant. Thanks for doing this! 🙏
Comment #19
quietone commentedOK, I have moved it. But it needs the guide maintainers, bnjmnm or lauriii, to add it to the menu.
Comment #20
wim leers@quietone Now https://www.drupal.org/docs/8/core/modules/ckeditor redirects to https://www.drupal.org/docs/contributed-modules/ckeditor, the child pages are still the same. Turns out this is because the child pages are still referencing
2829446as the guide instead of2829448.If I move it to the correct menu, I get a validation error:
The menu you chose does not belong to the selected groups.I did already update the child pages to make it clear they're targeting D10 contrib.
Comment #21
quietone commentedThere is one issue in ckeditor that needs to be resolved. It is assigned to xjm and I have pinged her about it. #3230035: Document CKEditor library build requirements
The documentation was moved last night and xjm fixed the aliases. I am double checking the changes. This is what I found.
Works with Drupal: ^9.4 || ^10, which is also on Deprecated and obsolete modules and themes . Because of that I've the CKEditor contrib wiki pages to begin with a statement that clarifies that the documentation is for the contrib version, that core is using CKEdito5 and to remove the "[Drupal 10]".@Wim Leers, I hope that is correct and fits with your intentions.
Comment #22
quietone commentedHeard back from xjm and the issue referred to in #21 stays in the core queue. Therefore I think everything is complete here, except the porting. If Wim Leers disagrees with the changes I made to the docs we can discuss but it does not hold up this issue, the documentation has been moved.
Comment #23
wim leers#21: I prefixed it with
[Drupal 10]specifically because you really ought to only install this contrib module if you intend to keep using CKEditor 4 in Drupal 10. You don't need it in Drupal 9.4 or 9.5. It's only 9.4 and 9.5-installable for compatibility/composer facade shenanigans …I'm fine with the changes you made/proposed — I didn't feel strongly about it anyway, because … it's going to be confusing anyway 😅 The d.o handbooks really aren't designed to handle multiple (major) Drupal versions well 😶🌫️
Thank you very much for your help in sorting this out! 🙏
So, marking this fixed! 🥳
Comment #24
quietone commented@Wim Leers, thanks. I agree this could be confusing. On the positive side it is a wiki page so others can improve upon it.
Comment #25
wim leersYep!