Problem/Motivation

Color module relies on the Farbtastic library, and Color is deprecated in Drupal 9.5 and removed in Drupal 10. We don't otherwise use this library in core so we can deprecate it in 9.5 for removal in Drupal 10.

Steps to reproduce

Proposed resolution

Mark the Farbtastic library as deprecated.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The core/jquery.farbtastic library has been deprecated.
The Color module relies on the Farbtastic library, and that module is deprecated in Drupal 9.5 and removed in Drupal 10.
We don't otherwise use this library in core, so we deprecate it in Drupal 9.5.0 for removal in Drupal 10.0.0.

Comments

longwave created an issue. See original summary.

longwave’s picture

Issue summary: View changes
andypost’s picture

Is there example? Do we need a legacy test for it?

spokje’s picture

Assigned: Unassigned » spokje
spokje’s picture

Assigned: spokje » Unassigned
Status: Active » Needs review
StatusFileSize
new9.89 KB
spokje’s picture

StatusFileSize
new9.89 KB
spokje’s picture

StatusFileSize
new9.94 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3306208-d10_1-7.patch, failed testing. View results

spokje’s picture

Assigned: Unassigned » spokje
spokje’s picture

StatusFileSize
new9.93 KB
andypost’s picture

Status: Needs work » Needs review

Looks great 💚

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Looks great to me too... although PopperJS might not have been the best choice; #3301545: Remove popperjs from Drupal 10

Still we can get this in first and deal with that later!

spokje’s picture

although PopperJS might not have been the best choice; #3301545: Replace popperjs with floating-ui

Meh, it actually took me a while to find a asset that wasn't on the way out. Never saw the re-branding of popper into floating-ui issue.
O well, as @longwave said: We can deal with that later on.

spokje’s picture

Assigned: spokje » Unassigned
quietone’s picture

The deprecation is for 9.5 so restarting a test for 9.5.

Also changing parent to the 9.5 Meta for deprecation.,

lauriii’s picture

I think we still need to add a draft release note to the issue summary for this.

We may have to change these tests again soon because Popper.js is now Floating UI: https://github.com/floating-ui/floating-ui 😅

I think we should do this. We couldn't have done this before removal of color so I hope we get an exception for doing this in 9.5.x for removal in 10.0.x. Technically this would have to be deprecated for removal from Drupal 11. Tagging for release manager review to get a sign-off from a release manager for the exception.

quietone’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new876 bytes
new9.89 KB

The patch didn't apply so I rerolled.

spokje’s picture

Maybe a bit(?) unclear due to all the CI Aborted messages, but patch #5 is against 9.5.x.

lauriii’s picture

Status: Needs review » Reviewed & tested by the community

Restoring status as #17 is same patch as #5 which was previously RTBC.

mondrake’s picture

Where would a replacement for D10 be available? See #3306210-3: Remove Farbtastic library from core.

spokje’s picture

There is indeed (some) dependency on core/jquery.farbtastic in contrib: https://git.drupalcode.org/search?repository_ref=&scope=blobs&snippets=f...

Unsure if that should stop declaring it deprecated, but for removal the above is a valid question IMHO.

mondrake’s picture

Unsure if that should stop declaring it deprecated

No, no, let's proceed - that's what deprecations are for...

catch’s picture

Quite a few of the contrib mentions are from Drupal core being bundled into install profiles, a handful of usages though but agreed we should go ahead and deprecate.

One last question for me though is whether we need a jquery farbtastic module in contrib for those modules to then depend on, or whether they should just sort it out themselves.

mondrake’s picture

One last question ...

my vote would go for either including the lib in the (now) contrib Color module (that would go bananas without), or a self-sufficient farbtastic module à la jQueryUI replacement modules.

andypost’s picture

+1 to add to color, that's the what for the module is

andypost’s picture

quietone’s picture

alexpott’s picture

We need a D10.1 version of the patch. #17 does 9.5.x and #10 does 10.0 but does not apply to 10.1.

spokje’s picture

StatusFileSize
new9.98 KB

Tough crowd in here :)

Added 10.1.x patch.

quietone’s picture

StatusFileSize
new2.27 KB

Here's the diff between 16 and 29.

alexpott’s picture

Can we get a release note as per #16

spokje’s picture

Issue summary: View changes
Issue tags: +10.0.0 release notes
spokje’s picture

Snippet added, also tagged with 10.0.0 release notes

alexpott’s picture

Issue tags: +9.5.0 release notes
alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs release manager review, -Needs release note

Committed e1ae3a337d and pushed to 10.1.x. Thanks!
Committed de839e1e62 and pushed to 10.0.x. Thanks!
Committed c69a661 and pushed to 9.5.x. Thanks!

@catch reviewed this as a release manager in #23

  • alexpott committed e1ae3a3 on 10.1.x
    Issue #3306208 by Spokje, quietone: Deprecate farbtastic in 9.5.x
    

  • alexpott committed de839e1 on 10.0.x
    Issue #3306208 by Spokje, quietone: Deprecate farbtastic in 9.5.x
    

  • alexpott committed c69a661 on 9.5.x
    Issue #3306208 by Spokje, quietone: Deprecate farbtastic in 9.5.x
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.