Problem/Motivation
Color module relies on the Farbtastic library, and Color is deprecated in Drupal 9.5 and removed in Drupal 10. We don't otherwise use this library in core so we can deprecate it in 9.5 for removal in Drupal 10.
Steps to reproduce
Proposed resolution
Mark the Farbtastic library as deprecated.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
The core/jquery.farbtastic library has been deprecated.
The Color module relies on the Farbtastic library, and that module is deprecated in Drupal 9.5 and removed in Drupal 10.
We don't otherwise use this library in core, so we deprecate it in Drupal 9.5.0 for removal in Drupal 10.0.0.
Comments
Comment #2
longwaveComment #3
andypostIs there example? Do we need a legacy test for it?
Comment #4
spokjeComment #5
spokjeComment #6
spokjeComment #7
spokjeComment #9
spokjeComment #10
spokjeComment #11
andypostLooks great 💚
Comment #12
longwaveLooks great to me too... although PopperJS might not have been the best choice; #3301545: Remove popperjs from Drupal 10
Still we can get this in first and deal with that later!
Comment #13
spokjeMeh, it actually took me a while to find a asset that wasn't on the way out. Never saw the re-branding of popper into floating-ui issue.
O well, as @longwave said: We can deal with that later on.
Comment #14
spokjeComment #15
quietone commentedThe deprecation is for 9.5 so restarting a test for 9.5.
Also changing parent to the 9.5 Meta for deprecation.,
Comment #16
lauriiiI think we still need to add a draft release note to the issue summary for this.
We may have to change these tests again soon because Popper.js is now Floating UI: https://github.com/floating-ui/floating-ui 😅
I think we should do this. We couldn't have done this before removal of color so I hope we get an exception for doing this in 9.5.x for removal in 10.0.x. Technically this would have to be deprecated for removal from Drupal 11. Tagging for release manager review to get a sign-off from a release manager for the exception.
Comment #17
quietone commentedThe patch didn't apply so I rerolled.
Comment #18
spokjeMaybe a bit(?) unclear due to all the CI Aborted messages, but patch #5 is against
9.5.x.Comment #19
lauriiiRestoring status as #17 is same patch as #5 which was previously RTBC.
Comment #20
mondrakeWhere would a replacement for D10 be available? See #3306210-3: Remove Farbtastic library from core.
Comment #21
spokjeThere is indeed (some) dependency on
core/jquery.farbtasticin contrib: https://git.drupalcode.org/search?repository_ref=&scope=blobs&snippets=f...Unsure if that should stop declaring it deprecated, but for removal the above is a valid question IMHO.
Comment #22
mondrakeNo, no, let's proceed - that's what deprecations are for...
Comment #23
catchQuite a few of the contrib mentions are from Drupal core being bundled into install profiles, a handful of usages though but agreed we should go ahead and deprecate.
One last question for me though is whether we need a jquery farbtastic module in contrib for those modules to then depend on, or whether they should just sort it out themselves.
Comment #24
mondrakemy vote would go for either including the lib in the (now) contrib Color module (that would go bananas without), or a self-sufficient farbtastic module à la jQueryUI replacement modules.
Comment #25
andypost+1 to add to color, that's the what for the module is
Comment #26
andypostFiled #3306607: Add farbtastic library to color module because it was deprecated in core 9.5
Comment #27
quietone commentedComment #28
alexpottWe need a D10.1 version of the patch. #17 does 9.5.x and #10 does 10.0 but does not apply to 10.1.
Comment #29
spokjeTough crowd in here :)
Added
10.1.xpatch.Comment #30
quietone commentedHere's the diff between 16 and 29.
Comment #31
alexpottCan we get a release note as per #16
Comment #32
spokjeComment #33
spokjeSnippet added, also tagged with
10.0.0 release notesComment #34
alexpottComment #35
alexpottCommitted e1ae3a337d and pushed to 10.1.x. Thanks!
Committed de839e1e62 and pushed to 10.0.x. Thanks!
Committed c69a661 and pushed to 9.5.x. Thanks!
@catch reviewed this as a release manager in #23