Problem/Motivation

Tests on 5.0.x seem to be broken, which prevents patches from being automatically tested.

Steps to reproduce

Create a new issue on drupal.org, attach a patch and set the status to Needs review. Alternatively, just run tests locally - you'll see the error 

Drupal\Tests\features\Kernel\FeaturesGenerateTest::testExportWrite
Symfony\Component\DependencyInjection\Exception\LogicException: Impossible to call set() on a frozen ParameterBag.
CommentFileSizeAuthor
#3 features-broken-tests-3306198-3.patch1.99 KBspleshka

Comments

Spleshka created an issue. See original summary.

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented

Looks like it was caused by this commit https://git.drupalcode.org/project/features/-/commit/a4801ce

spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Active » Needs review
StatusFileSize
new features-broken-tests-3306198-3.patch1.99 KB

I found the root cause of the issue. It was an interesting issue with frozen ParameterBag, but luckily there's a workaround. See comment in the patch.

  • nedjo committed e0217cd on 5.0.x 
    Issue #3306198 by Spleshka: Broken tests on 5.0.x
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Thanks, nice sleuthing and well explained in the code comments. Applied.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.