Problem/Motivation

The acquia_lift_inspector is using the underscore library via the template() function, so it can parse the html template. Since core/underscore is deprecated (https://www.drupal.org/node/3273118), we should remove this function and replace it with vanilla js alternative. That way we can remove the dependency on underscore library completely

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork acquia_lift-3305999

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nkoporec created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Issue summary: View changes

nkoporec opened merge request !2

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Active » Needs review

japerry made their first commit to this issue’s fork.

  • japerry committed a3d7878 on 8.x-4.x authored by nkoporec 
    Issue #3305999 by nkoporec: Replace _.template() with vanilla JS...
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.