Problem/Motivation

$ drush dmu-upgrade permission_grid --path=modules/contrib/permission_grid

says:

Indexing...
done.

And my code is unchanged.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

joachim created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

What's your PHP version?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

And Drupal core version and DMU version :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Postponed (maintainer needs more info)
joachim’s picture

joachim commented
Status: Postponed (maintainer needs more info) » Active

PHP 8.0.8 (cli) (built: Sep 30 2021 13:54:04) ( NTS )

Drush Launcher Version: 0.10.1
Drush Commandline Tool 11.1.1

Drupal version : 9.5.0-dev

name : drupal/drupalmoduleupgrader
descrip. : A Drush command to update Drupal 7 modules to Drupal 8 or 9.
keywords : Drupal, PHP_CodeSniffer, phpcs, standards, update, upgrade
versions : * 1.9.0

I don't see any errors at all, which is weird!

However, this produces a report:

$ drush dmu-analyze permission_grid --path=modules/contrib/permission_grid

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This could be because of #3280719: dmu_upgrade not compatible with PHP 8.0+.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Yeah analyze works because it supports all the constructs you used in your Drupal 7 code. However PHP 8 has new tokens for the language constrcuts used in the Drupal 9/10 generated code, which Pharborist does not support. Help is welcome in #3280719: dmu_upgrade not compatible with PHP 8.0+, I made good progress but would need more help.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: dmu-upgrade doesn't do anything » dmu-upgrade doesn't do anything on PHP 8, only dmu-analyze works
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Closed (duplicate)

I worked in the past two days with Claude Code to fix this. Pharborist now passes all its tests on both PHP 8.1 and 8.4 (and has new tests for new PHP 8 token constants). Also https://www.drupal.org/project/drupalmoduleupgrader/releases/2.0.0-alpha2 is available that now uses the new Pharborist version. Will credit you for the report.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.