Problem/Motivation

This test is a regression test for #2807263: Impossible to write unit tests involving Vocabulary, because TAXONOMY_HIERARCHY_(DISABLED|SINGLE|MULTIPLE) are defined in taxonomy.module instead of VocabularyInterface, which was needed because of constants defined in the module file:

 * When a Vocabulary entity is unserialized before the modules have been loaded
 * (which happens in the KernelPreHandle Stack middleware), then the constants
 * that the Vocabulary entity uses are not yet available because they are set in
 * taxonomy.module. This means that for example the PageCache middleware cannot

However, taxonomy.module no longer contains any constants.

This test should no longer be needed.

Steps to reproduce

Proposed resolution

Remaining tasks

- agree that it can be removed
- remove the test & the test module

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3305764

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue tags: +Novice

I agree that it can be removed. Tagging as novice since the actual steps to remove the test and test module are easy.

brandonlira made their first commit to this issue’s fork.

brandonlira opened merge request !11296

brandonlira’s picture

brandonlira commented

I’ve created a merge request to remove VocabularySerializationTest since it’s no longer needed. You can find it here: https://git.drupalcode.org/project/drupal/-/merge_requests/11296.

Let me know if any feedback or additional changes are required.

Thank you!

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a rebase.

charlliequadros made their first commit to this issue’s fork.

charlliequadros’s picture

charlliequadros commented

Hi @penyaskito,
I resolved the conflict in the MR.

charlliequadros’s picture

charlliequadros commented
Status: Needs work » Needs review

  • catch committed 8a57ede1 on 11.x 
    Issue #3305764 by brandonlira, charlliequadros, joachim: remove...
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Since it's just removing the file, going ahead from needs review here (would have been OK to restore the RTBC).

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.