Problem/Motivation

Appending "Do not include trailing slashes with URLs" to the instructional comments will eliminate much frustration with allowedOrigins in services.yml.

Steps to reproduce

1. add urls to the allowedOrigins section of services.yml
2. include a slash at the end of each url
3. note the CORS failure
4. remove the trailing slash
5. note the CORS success

Proposed resolution

Adjust comment to say `# Configure requests allowed from specific origins. Do not include trailing slashes with URLs.

Remaining tasks

Review/improve merge request

User interface changes

Code comment only

API changes

None

Data model changes

None

Release notes snippet

Improve instructional comment to include specific requirements for urls.

Issue fork drupal-3305748

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kay_v created an issue. See original summary.

kay_v’s picture

kay_v commented

This issue is a good candidate for a 'novice' reviewer.

kay_v’s picture

kay_v commented
Status: Active » Needs review
kay_v’s picture

kay_v commented
Issue tags: +Novice
mahesh bandhiya’s picture

mahesh bandhiya commented
Status: Needs review » Reviewed & tested by the community

tested by adding trailing slash. instruction is helpful

Spokje opened merge request !2699

spokje’s picture

spokje
Primary language Dutch
commented

Opened Merge Request with the changes that were already in the branch, so the changes can be tested.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed bc1a8d8493 to 10.1.x and ecba971698 to 10.0.x and 9685ecbeac to 9.5.x. Thanks!

Backported to 9.5.x as this is a documentation improvement.

  • alexpott committed bc1a8d8 on 10.1.x 
    Issue #3305748 by kay_v, Spokje, bmahesh03121: improve instructions for...

  • alexpott committed ecba971 on 10.0.x 
    Issue #3305748 by kay_v, Spokje, bmahesh03121: improve instructions for...

  • alexpott committed 9685ecb on 9.5.x 
    Issue #3305748 by kay_v, Spokje, bmahesh03121: improve instructions for...

Spokje closed merge request !2699

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.