The template provided by this module has a bunch of texts on it that should be passed by the twig filter "t"

For example:

<h3> Recent Created Node</h3>

Should be:

<h3>'Recently created nodes'|t</h3>

CommentFileSizeAuthor
#16 homepage-after-patch.png600.72 KBclarkssquared
#16 showmore-before.png916.46 KBclarkssquared
#16 recent-created-node-before.png950.13 KBclarkssquared
#16 user-activity-log-installed-version.png187.17 KBclarkssquared
#16 code-after-patch.png197.14 KBclarkssquared
#16 code-before-patch.png158.64 KBclarkssquared
#12 Screenshot from 2022-09-05 18-32-20.png70.27 KBanjali rathod
#11 adding-translate-text-3304829-11.patch1.06 KBnitin_lama
#3 template-text-translate-3304829-2.patch387 bytesdharti patel

Issue fork user_activity_log-3304829

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pcambra created an issue. See original summary.

dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel
dharti patel’s picture

dharti patel commented
Assigned: dharti patel » Unassigned
Status: Active » Needs review
StatusFileSize
new template-text-translate-3304829-2.patch387 bytes

Resolved the issue and create patch for the same.
Please review the patch.

Thanks!

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Needs work
Issue tags: +Novice

Well it's not just that one text, there are more in the template

Yujiman85 made their first commit to this issue’s fork.

yujiman85’s picture

yujiman85 commented
Assigned: Unassigned » yujiman85

Yujiman85 opened merge request !1

yujiman85’s picture

yujiman85 commented
Assigned: yujiman85 » Unassigned
Status: Needs work » Needs review

I added the filter where I thought appropriate. I did NOT add it to the user-entered fields that use "node.xxx". As far as I'm aware you're not supposed to pass user-entered info through the t filter because of security reasons. Please correct me if I'm wrong. I made a merge request with the current changes, let me know if anything else needs to be added.

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Status: Needs review » Needs work

Lets keep the commented on sentence also along with the translatable function

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama

Patch incoming.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
Status: Needs work » Needs review
StatusFileSize
new adding-translate-text-3304829-11.patch1.06 KB

Updated patch with #9 suggestion.

anjali rathod’s picture

anjali rathod
Primary language English
Location India
commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2022-09-05 18-32-20.png70.27 KB

Sorry missed to mention above that node.title and node.subject are also text that should be translated.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented

I think node.title and node.subject translation is not required as {{ node.title }}, {{ node.subject }} will auto load the translations from the node field value. @anjali-rathod

yujiman85’s picture

yujiman85 commented

I agree with @nitin_lama. Is there anything else in this module that needs the t filter?

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs work » Needs review

The module only provides 1 template, so there is nothing else to translate. This can be reviewed.

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new code-before-patch.png158.64 KB
new code-after-patch.png197.14 KB
new user-activity-log-installed-version.png187.17 KB
new recent-created-node-before.png950.13 KB
new showmore-before.png916.46 KB
new homepage-after-patch.png600.72 KB

Hi nitin_lama,

I'm new to this module and applied patch #11 to the User Activity Log module against
8.x-1.x-dev and it shows me an error in my homepage.

Please see the screenshots attached.

Thank You.

chanderbhushan’s picture

chanderbhushan commented
Status: Needs work » Fixed

I have fixed and created the new release

thanks everyone for testing and adding patchs

chanderbhushan’s picture

chanderbhushan commented
Status: Fixed » Closed (fixed)