Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 reroll_diff_4-14.txt1.86 KBravi.shankar
#14 3304371-14.patch2.09 KBravi.shankar
#4 3304371-4.patch2.09 KBbnjmnm
#2 AjaxBlockTestFail.patch3.54 KBbnjmnm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Status: Active » Needs review
FileSize
AjaxBlockTestFail.patch3.54 KB
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented

#2 👆 runs the test 1200 times

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
FileSize
3304371-4.patch2.09 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

I want to RTBC this, since it looks completely simple and straightforward to me, but I'm wondering about that SQLite failure. I know SQLite database locks are a known problem for us, but I'd feel better if someone in the know (looking at you, @xjm) could confirm that those are affecting HEAD from time to time.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

I always, always queue only MySQL and Maria environments for testing random fails, because Postgres and SQLite are prone to DB problems. SQLite especially is prone to database locks, and that's what happened here:
SQLSTATE[HY000]: General error: 5 database is locked.Does the database file exist?Does web server have permission to write to the database file?Does the web server have permission to write to the directory the database file should be created in?

So we can ignore that result. However, I'm going to queue a couple more jobs on MySQL environments to be safe.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Okay, then I'm kicking this to RTBC on the assumption that the MySQL jobs will pass.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

On the other hand, looks like a reroll of #2 is necessary...

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs work » Reviewed & tested by the community

I think it is RTBC for 10.1.x; just we will need a different backport patch for 9.4.x.

  • xjm committed f33a8be on 10.1.x 
    Issue #3304371 by bnjmnm: Fix intermittent failure in AjaxBlockTest

  • xjm committed 78fac59 on 10.0.x 
    Issue #3304371 by bnjmnm: Fix intermittent failure in AjaxBlockTest

(...

  • xjm committed e2a229f on 9.5.x 
    Issue #3304371 by bnjmnm: Fix intermittent failure in AjaxBlockTest

(...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Needs work

Committed to 10.1.x, 10.0.x, and 9.5.x, thanks!

NW for the 9.4.x backport.

ravi.shankar’s picture

ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3304371-14.patch2.09 KB
reroll_diff_4-14.txt1.86 KB

Added a patch for Drupal 9.4.x.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

I compared the patch in #14 to what was committed. They look identical to me, so I queued up a bunch more MySQL environments. If they come back green, and I'm guessing they will, I'd say this is RTBC.

  • xjm committed 4dcc6bb on 9.4.x 
    Issue #3304371 by bnjmnm, ravi.shankar, phenaproxima, xjm: Fix...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.