Problem/Motivation

1x: The Drupal\Tests\ajax_comments\Functional\AjaxCommentsSettingsFormTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426
1x in DrupalListener::startTest from Drupal\Tests\Listeners

1x: Calling Drupal\Tests\WebAssert::addressEquals with more than one argument is deprecated in drupal:9.1.0 and will throw an \InvalidArgumentException in drupal:10.0.0. See https://www.drupal.org/node/3162537
1x in AjaxCommentsSettingsFormTest::testAjaxCommentsSettings from Drupal\Tests\ajax_comments\Functional

1x: The Drupal\Tests\ajax_comments\FunctionalJavascript\AjaxCommentsFunctionalTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426
1x in DrupalListener::startTest from Drupal\Tests\Listeners

1x: Javascript Deprecation: The Modernizr touch events test is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0. See https://www.drupal.org/node/3277381 for information on its replacement and how it should be used.
1x in AjaxCommentsFunctionalTest::testCommentPosting from Drupal\Tests\ajax_comments\FunctionalJavascript

Proposed resolution

Fix deprecations triggered in automated tests

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork ajax_comments-3303855

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review

1x: Javascript Deprecation: The Modernizr touch events test is deprecated in Drupal 9.4.0 and will be removed in Drupal 10.0.0. See https://www.drupal.org/node/3277381 for information on its replacement and how it should be used.
1x in AjaxCommentsFunctionalTest::testCommentPosting from Drupal\Tests\ajax_comments\FunctionalJavascript

This last deprecation is triggered by core/collapse and core/date libraries, so fixing this deprecation is out of scope for this issue.

idebr opened merge request !5

  • 4b2e1f4 committed on 8.x-1.x 
    Issue #3303855 by idebr: Fix deprecations triggered in automated tests
idebr’s picture

idebr commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

klemendev’s picture

klemendev commented

Neat, looking forward to a full D10 release