The Views Dynamic Entity Row module provides the possibility to change the view mode for the Views entity row.

There is a similar module but works a bit differently. They use a gap for changing entity view mode for the Views row. In our case, we use a different, more flexible approach, which includes the following possibilities:

  1. You can set up different view modes for each node. This means that you can go to the node edit form and change the view for displaying in a specific view.
  2. We have the possibility to set up default view mode for all rows. In case you want to change displaying styles only for a few nodes, others will be displayed as default.
  3. Provides useful and simple configuration form for the Entity types that can use this functionality.

Other Modules

Project link

https://www.drupal.org/project/views_dynamic_entity_row

Comments

_shY created an issue. See original summary.

bbu23’s picture

bbu23
Location 🇪🇺🇪🇺🇪🇺
commented

Hello and thank you for your contribution.

Overall, the module looks pretty good and there are no coding standards/best practices issues, but unfortunately there's not enough code to review from the person who applied.

Looking back in the history, there was another maintainer that doesn't seem to be a maintainer anymore who built the project from scratch and wrote most of the code.

Another note is that the status of the project is "seeking new maintainer" - not sure if this is valid or a mistake -, and the project currently has 3 maintainers, but the other 2 maintainers already have the vetted role.

Not sure what to do here, so I'll leave the issue in "Needs review" for someone else to review as well.

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented

Thank you for your notices.

Yes, that's correct, I taken this module from the contrib modules adoption system.

About project status, seems like I forget to change it, because for now I fully maintain this module.

I'm sorry if this is wrong approach for putting security advisory coverage application, I didn't saw requirements or notes about that.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

Since the project is being used for this application, for the time this application is open, only the user who created the application can commit code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Usually, we accept applications that use a project for which the user who applies made most of (or all) the commits. In this case, since the user who created the project and made the first (and most of the) commits did it six years ago, I am going to accept the application.

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented

Thanks, @apaderno!
I'm looking forward to any comments or changes request.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Major

I am changing priority as per Review process for security advisory coverage: What to expect / Application Review Timelines.

To the reviewers: Please set the priority to Normal after a review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: [D9] Views Dynamic Entity Row » [8.x-1.x] Views Dynamic Entity Row
Issue summary: View changes
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Fixed

manual review:

  1. You are storing the view mode per entity UUID in the config system. That could be a performance problem if your list of entities grows large that have this configured. Form my understanding I would do the view mode setting per entity as field on the entity (with its own database table).
  2. DynamicEntityRow::getEntityTranslationRenderer(): is there any reason why your dynamic view mode only works with ***LANGUAGE_entity_translation*** and not ***LANGUAGE_entity_default***? Please add a code comment.

Otherwise looks good to me!

Thanks for your contribution, Kostia!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.