Problem/Motivation

This is part of the CSS modernization initiative.

Steps to reproduce

The stylesheet at https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/themes/claro/css/components/form--checkbox-radio.pcss.css needs to be refactored to make use of modern CSS and Drupal core's PostCSS tooling.

Proposed resolution

Use CSS Logical Properties where appropriate
Use CSS nesting where appropriate

Remaining tasks

We need two patches. One for Drupal 9.5.x and one for Drupal 10.0.x
We need a followup issue to refactor this component in Drupal 10.0.x to make use of component-level CSS custom properties and remove IE specific style definitions.

User interface changes

None. There should be no visual differences.

CommentFileSizeAuthor
#11 Screenshot 2023-06-29 at 10.06.20 AM.png209.21 KBgauravvvv
#10 interdiff-3303549-8_10.txt1.97 KBgauravvvv
#10 3303549-10.patch10.31 KBgauravvvv
#8 3303549-8.patch10.29 KBstanzin
#3 3303549-version10.0.x.patch18.06 KBaditya4478
#2 3303549-version9.5.x.patch18.38 KBaditya4478

Comments

sasanikolic created an issue. See original summary.

aditya4478’s picture

aditya4478 commented
Status: Active » Needs review
StatusFileSize
new 3303549-version9.5.x.patch18.38 KB
aditya4478’s picture

aditya4478 commented
Version: 9.5.x-dev » 10.0.x-dev
StatusFileSize
new 3303549-version10.0.x.patch18.06 KB
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Parent issue: » #3324398: [META] Update Claro CSS with new coding standards
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

Believe this is postponed via our conversation a few weeks ago @ckrina. For the followup and a path forward

aditya4478’s picture

aditya4478 commented
Status: Postponed » Needs work
stanzin’s picture

stanzin commented
Version: 10.0.x-dev » 11.x-dev
Status: Needs work » Needs review
StatusFileSize
new 3303549-8.patch10.29 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: -Needs followup +Needs screenshots

Since this is different then #3 it will need updated screenshots + an interdiff please

Thanks.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3303549-10.patch10.31 KB
new interdiff-3303549-8_10.txt1.97 KB

Updated CSS logical properties in patch #8, added interdiff for same.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
Issue tags: -Needs screenshots
StatusFileSize
new Screenshot 2023-06-29 at 10.06.20 AM.png209.21 KB

Added before and after patch screenshot

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks!

The last submitted patch, 8: 3303549-8.patch, failed testing. View results

The last submitted patch, 8: 3303549-8.patch, failed testing. View results

The last submitted patch, 8: 3303549-8.patch, failed testing. View results

  • ckrina committed d256cf4a on 11.x 
    Issue #3303549 by Aditya4478, Gauravvvv, Stanzin, smustgrave: Refactor...
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Committed d256cf4 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.