Problem/Motivation

When using the XML or CSV parser, some people seem to pick "Blank source" instead of "CSV column source" or "XML Xpath source" and then wonder why no data gets parsed.

Additionally, I think the list of source options could be improved more when using categories.

Before After
You cannot easily see which are CSV sources and which are blank sources.
Some sources belong to the RSS parser, other are from the feed entity.

Steps to reproduce

  1. Create a feed type, select the CSV parser.
  2. Go to the mapping form.
  3. Select a target.
  4. Inspect the dropdown in the column "Source".

You potentially see a long list of options.

Proposed resolution

  • At least add a help text under the text box that appears when selecting the option "New Blank source..."
  • Categorize the source options so that it becomes clear which ones are blank, which ones are CSV, which ones are from the feed entity.

Remaining tasks

  • Use custom source label as category name in source selector

User interface changes

  • On the mapping form, an additional help text will be displayed for blank sources.
  • The options from the source selection list will get categories.

API changes

The FeedsSource plugin type gets an additional key called "category".

Data model changes

None.

Issue fork feeds-3303166

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

Status: Active » Needs review
StatusFileSize
new83.18 KB

Now the source options list can look like this:

megachriz’s picture

Issue summary: View changes
StatusFileSize
new121.92 KB

Put before/after images in table in issue summary.

  • MegaChriz committed e53d787 on 8.x-3.x
    Issue #3303166 by MegaChriz: Categorize source options on the mapping...
megachriz’s picture

Status: Needs review » Fixed

Merged the code!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.