Problem/Motivation

Steps to reproduce

When we tryed to access this module with PHP 8.0 version the error round(): Argument #1 ($num) must be of type int|float, string given occurs because the round function need to be a type int.

Proposed resolution

I created a patch who apply this cast for the variables values.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 weather_weather_parser.patch870 bytesmarim49
weather_weather_parser.patch1.01 KBmarim49

Comments

marim49 created an issue. See original summary.

marim49’s picture

marim49 commented
StatusFileSize
new weather_weather_parser.patch870 bytes
marim49’s picture

marim49 commented
Status: Active » Needs review
Issue tags: +ciandt-contrib, +#ciandt-contrib
fadonascimento’s picture

fadonascimento commented

Hey @marim49 thanks for the patch, the patch #2 works for me, great.

fadonascimento’s picture

fadonascimento commented
Status: Needs review » Reviewed & tested by the community
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -PHP8 +PHP 8.0
toddy’s picture

toddy commented
Assigned: marim49 » toddy

Hi marim49, thanks for your investigation and patch. However, it's not entirely correct, because the value given to the round() function is not an integer, but a float. I've changed that accordingly.

Regards,
Tobias

  • 560cee0 committed on 7.x-3.x 
    Issue #3302906 by toddy: round(): Argument #1 ($num) must be of type int...
toddy’s picture

toddy commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.