Closed (fixed)
Project:
Signup
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
5 Nov 2008 at 03:46 UTC
Updated:
19 Nov 2008 at 09:02 UTC
Jump to comment: Most recent file
When you create a new node, that is signup-enabled by default, you end up with a broken link to the "Signups" tab since there's no nid yet:
$hint = t('If enabled, you can control whether users may sign up by visiting the !signups tab and toggling if signups are %open or %closed for this @node_type.', array('!signups' => l(t('Signups'), 'node/'. $node->nid .'/signups'), '%open' => t('open'), '%closed' => t('closed'), '@node_type' => strtolower(node_get_types('name', $form['type']['#value']))));
$node is NULL on new issues, so we get a PHP warning and a broken link.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 330281_signup_help_text_broken_link.2.patch | 1.28 KB | dww |
| #1 | 330281_signup_help_text_broken_link.1.patch | 936 bytes | dww |
Comments
Comment #1
dwwSimple patch that just hides that help text entirely during issue creation.
Comment #2
dwwI suppose we could conditionally define the replacement for !signups to be the link if there's a node, or just text on new node creation...
Comment #3
stborchertWorks and can be committed.
Comment #4
dwwCommitted to HEAD, DRUPAL-5--2, and DRUPAL-5. Thanks for the review.