Problem/Motivation

Right now we have to add composer self-update 2.3.5 to our drupalci.yml because ComposerExecutableValidator will only validate 2.3.5 and above.
In #3275256: Raise the minimum required version of Composer to 2.3.5 the reason for only supporting 2.3.5 was

This is also fixed in a 2.2.x line, but it's simpler for us to just require Composer 2.3.5 or later. So let's do that.

Now in Project Browser that team is asking why they also have to have composer self-update 2.3.5 in their drupalci.yml. As far as I know there is no reason couldn't support both.

Proposed resolution

We could change \Drupal\package_manager\Validator\ComposerExecutableValidator::MINIMUM_COMPOSER_VERSION to version constraint and just use \Composer\Semver\Semver::satisfies

This would allow more people to use Automatic Updates and Project Browser.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

omkar.podey’s picture

Assigned: Unassigned » omkar.podey

omkar.podey’s picture

Status: Active » Needs review
tedbow’s picture

Status: Needs review » Needs work

@omkar.podey this is looking good. Just a couple requests for wording changes

omkar.podey’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Status: Needs review » Needs work

Couple small requests, but this looks pretty good to me.

omkar.podey’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Assigned: omkar.podey » tedbow

Assigning to @tedbow for final sign-off and commit, but I have no objections. Nice work!

phenaproxima’s picture

Title: Should we support Composer 2.2.* also? » Support Composer 2.2
Component: Code » Package Manager
phenaproxima’s picture

Status: Needs review » Needs work

Ugh, sorry, found one more thing. That said, I'm not sure how to address it, so I think it might be for me and Ted to figure out.

tedbow’s picture

Assigned: tedbow » phenaproxima

Assigning to @phenaproxima to push up changes here https://git.drupalcode.org/project/automatic_updates/-/merge_requests/41...
I would like to see the test failures related to this. thanks

kunal.sachdev made their first commit to this issue’s fork.

phenaproxima’s picture

Status: Needs work » Needs review

It's amazing what a month or two away will do; I figured out the problem in 10 minutes with a little help from Xdebug.

I think the tests will pass now.

tedbow’s picture

Assigned: phenaproxima » Unassigned
Status: Needs review » Reviewed & tested by the community

@phenaproxima nice work on the test fix!

RTBC, go to merge if tests pass

phenaproxima’s picture

phenaproxima’s picture

Category: Bug report » Feature request

phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, everyone! Merged into 8.x-2.x.

effulgentsia’s picture

The project page still says "Automatic Updates requires Composer 2.3.5 or later.". Should that be changed?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

Issue tags: +core-mvp