Problem/Motivation
Right now we have to add composer self-update 2.3.5 to our drupalci.yml because ComposerExecutableValidator will only validate 2.3.5 and above.
In #3275256: Raise the minimum required version of Composer to 2.3.5 the reason for only supporting 2.3.5 was
This is also fixed in a 2.2.x line, but it's simpler for us to just require Composer 2.3.5 or later. So let's do that.
Now in Project Browser that team is asking why they also have to have composer self-update 2.3.5 in their drupalci.yml. As far as I know there is no reason couldn't support both.
Proposed resolution
We could change \Drupal\package_manager\Validator\ComposerExecutableValidator::MINIMUM_COMPOSER_VERSION to version constraint and just use \Composer\Semver\Semver::satisfies
This would allow more people to use Automatic Updates and Project Browser.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3302524
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
omkar.podey commentedComment #4
omkar.podey commentedComment #5
tedbow@omkar.podey this is looking good. Just a couple requests for wording changes
Comment #6
omkar.podey commentedComment #7
phenaproximaCouple small requests, but this looks pretty good to me.
Comment #8
omkar.podey commentedComment #9
phenaproximaAssigning to @tedbow for final sign-off and commit, but I have no objections. Nice work!
Comment #10
phenaproximaComment #11
phenaproximaUgh, sorry, found one more thing. That said, I'm not sure how to address it, so I think it might be for me and Ted to figure out.
Comment #12
tedbowAssigning to @phenaproxima to push up changes here https://git.drupalcode.org/project/automatic_updates/-/merge_requests/41...
I would like to see the test failures related to this. thanks
Comment #14
phenaproximaIt's amazing what a month or two away will do; I figured out the problem in 10 minutes with a little help from Xdebug.
I think the tests will pass now.
Comment #15
tedbow@phenaproxima nice work on the test fix!
RTBC, go to merge if tests pass
Comment #16
phenaproximaComment #17
phenaproximaComment #19
phenaproximaThanks, everyone! Merged into 8.x-2.x.
Comment #20
effulgentsia commentedThe project page still says "Automatic Updates requires Composer 2.3.5 or later.". Should that be changed?
Comment #22
tedbow