$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tagclouds/
Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: localhost:9000 (through xdebug.client_host/xdebug.client_port) :-(
FILE: C:\Users\SI-001\Downloads\tagclouds\src\CloudBuilder.php
-------------------------------------------------------------------------------------------------
106 | WARNING | Node::load calls should be avoided in classes, use dependency injection instead
130 | WARNING | Node::load calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3302357-5.patch | 2.04 KB | sourabhjain |
| #2 | node-load-calls-should-be-avoided-3302357-2.patch | 2.64 KB | rakhi soni |
Comments
Comment #2
rakhi soni commentedKindly review patch,,
Comment #3
joseph.olstad╰❯ $ patch -p1 < node-load-calls-should-be-avoided-3302357-2.patch
patching file src/CloudBuilder.php
Hunk #1 FAILED at 4.
Hunk #2 FAILED at 28.
Hunk #3 FAILED at 103.
Hunk #4 FAILED at 127.
4 out of 4 hunks FAILED -- saving rejects to file src/CloudBuilder.php.rej
Comment #4
sourabhjainI will work on this.
Comment #5
sourabhjainI have updated the patch.
Please review.
Comment #6
asad_ahmed commentedPatch #5 applied cleanly and working fine for me and solve the issue mentioned above.
Comment #8
joseph.olstad