FILE: /home/drupal/myproject/PDF_using_mPDF/pdf_using_mpdf.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------


FILE: /home/drupal/myproject/PDF_using_mPDF/pdf_using_mpdf.module
--------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
  7 | ERROR   | [x] When importing a class with "use", do not include a leading \
  8 | ERROR   | [x] When importing a class with "use", do not include a leading \
 13 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 34 | WARNING | [ ] Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------------------------


FILE: /home/drupal/myproject/PDF_using_mPDF/src/Conversion/ConvertToPdf.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 16 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: /home/drupal/myproject/PDF_using_mPDF/src/Controller/GeneratePdf.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 20 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: /home/drupal/myproject/PDF_using_mPDF/pdf_using_mpdf.install
----------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  3 | ERROR   | [x] When importing a class with "use", do not include a leading \
 25 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 39 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
----------------------------------------------------------------------------------
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Dharti Patel created an issue. See original summary.

dharti patel’s picture

Assigned: dharti patel » Unassigned
Status: Active » Needs review
StatusFileSize
new7.52 KB

Kindely review this patch.

Thanks!

sourabhjain’s picture

Assigned: Unassigned » sourabhjain

I will review it.

sourabhjain’s picture

Assigned: sourabhjain » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new1.25 MB
new31.17 KB

I have reviewed the patch #2 and its looks good. Attaching before and after Screenshot for reference.
Moving to RTBC.

gilmord made their first commit to this issue’s fork.

gilmord’s picture

Version: 8.x-1.x-dev » 8.x-2.2
gilmord’s picture

Issue tags: +LutskGCW23
gilmord’s picture

Status: Reviewed & tested by the community » Fixed
gilmord’s picture

Status: Fixed » Closed (fixed)