[D9] Entity Reference Finder

It appears there are multiple project applications created using your account.
Since a successful completion of the project application process results in the applicant being granted the vetted role, there is no need to take multiple applications through the process. Once the first application has been successfully approved, the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers, which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as Closed (duplicate), with only one application left open.

If you prefer that we proceed through this review process with a different application, then feel free to close the application left open as a duplicate, and re-open one of the project applications which had been closed.

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

Since the project is being used for this application, for the time this application is open, only the user who created the application can commit code.

Hi

Automated Checks

1. phpcs with Drupal and DrupalPractice standards, shows no errors :)
2. phpstan/drupal-check shows:

   $ drupal-check --drupal-root=web web/modules/contrib/entity_reference_finder/
   
    2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
   
    ------ --------------------------------------------------------------------- 
     Line   src/Form/EntityReferenceFinderForm.php                               
    ------ --------------------------------------------------------------------- 
     235    Call to method getSetting() on an unknown class                      
            Drupal\field\Entity\Drupal\field\FieldConfigInterface.               
            💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
     235    Call to method getSetting() on an unknown class                      
            Drupal\field\Entity\Drupal\field\FieldConfigInterface.               
            💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
    ------ --------------------------------------------------------------------- 
   
    [ERROR] Found 2 errors                                                         
   
   Thanks for using drupal-check!
   
   Consider sponsoring the development of the maintainers which make drupal-check possible:
   
   - phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
   - phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
   - phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
   - drupal-check (mglaman)): https://github.com/sponsors/mglaman
   
   

   For the drupal-check you could add an inline variable type declaration comment, like

   /** @var \Drupal\field\FieldConfigInterface $def */
   

Manual Checks

1. On the Module page it would be nice to add more details on how to use this module, like pointing to the form, or adding a screenshot so the functionality provided by the module is more clear.
2. Similar as above, the module info file has a description "Module for searching all reference of an entity" but, if I'm using it in the correct way, what the module provides is a form that shows Entity Types that have an entity_reference field, so maybe the description could reflect that.
3. I was looking at the code in entity_reference_finder.module and since the min php version supported by Drupal is 7.4 I don't think the code in .module file is really needed. Even for latest Drupal 8 (even if D8 has reached EOL now) the min php version is 7.3. If I'm missing something here, please let me know.
4. On the entity_reference_finder.routing.yml file there is a hard-coded reference to fr french. I don't think this is needed.
   

   entity_reference_finder.page:
     path: '/admin/reports/entity_reference_finder'
     defaults:
       _form: '\Drupal\entity_reference_finder\Form\EntityReferenceFinderForm'
       _title: 'Entity References Finder'
       lang:  'fr' // -->Hardcoded language set to french.
     requirements:
       _permission: 'access administration entityreferencefinder'
   

Automated Review

All issues were resolved in latest dev version. Thanks :)

Manual Review

All suggestions covered.

Just a really minor thing (sorry for not noting this before!):

1. README file follows the template as suggested in https://www.drupal.org/node/2181737 BUT the filename should be README.txt ie: capital letters. Just a matter of changing the filename case.

Once that's done I'll set the issue to Reviewed so an administrator can take a look.

Thanks,
m

Setting as Reviewed as all Manual and Automated checks are OK.
Now an administrator should verify.

Thanks!

m

core_version_requirement: ^8 || ^9 || ^10

core_version_requirement requires Drupal 8.7.7, while semantic versioning requires Drupal 8.8.3, as previous Drupal versions don't handle it.
Since this project is using semantic versioning, the requirements for Drupal 8 should be changed. Since Drupal 8 isn't supported anymore, I would rather declare the project compatible with Drupal 9 and Drupal 10, if there aren't Drupal 8 sites using this project.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers too.