There are two migration related tests that have references to Bartik:
6 core/modules/color/tests/src/Kernel/Migrate/d7/MigrateColorTest.php
21 core/modules/color/tests/src/Kernel/Plugin/migrate/source/d7/ColorTest.phpAccording to @quietone in #3281430-5: Update non-migration Color tests to not use Bartik:
- core/modules/color/tests/src/Kernel/Migrate/d7/MigrateColorTest.php - This installs bartik, which is needed to test the migration of bartik configuration. In terms of this issue, there is nothing to do here.
- core/modules/color/tests/src/Kernel/Plugin/migrate/source/d7/ColorTest.php - No changes are needed here.
So the only test in the color module that actually installs bartik is core/modules/color/tests/src/Kernel/Migrate/d7/MigrateColorTest.php.
The current proposed solution by @catch in #3281430-17: Update non-migration Color tests to not use Bartik:
I'm not sure what to do with it either. We might to do something like mark it skipped and then re-enable in the contrib versions.
It looks like:
- If color is removed from core before bartik: We don't have to do anything with the remaining migration related test
- If bartik is removed from core before color: We mark the tests in MigrateColorTest as skipped and re-enable it in the Contrib version of the color module.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3301713-4.patch | 2.58 KB | quietone |
Comments
Comment #2
spokjeComment #3
quietone commentedcore/modules/color/tests/src/Kernel/Plugin/migrate/source/d7/ColorTest.php is a source plugin test and it does not need to be changed as stated in #3281430-5: Update non-migration Color tests to not use Bartik.
In #3281427: Update Block and Theme setting migrations to not use Bartik and Seven migrations were changed so that bartik blocks migrated to olivero and seven blocks to claro. So, here we can make the same decision to migrate bartik color to olivero color. I'll take a closer look.
Comment #4
spokjeThanks @quietone.
I think the problem here is that olivero doesn't use color any more.
AFAIK all new themes don't and there is a beginning of a start of a plan issue somewhere to get something of a color API to replace the working of the color module.
(The vagueness of the above sentence shows how much I actually understand of this...)
Bottom-line: I don't think there's an "olivero color" to migrate to.
Happy to be pointed out as being ridiculously wrong about all of the above.
Comment #5
quietone commentedHow about this.
The title is nearly identical to an existing issue. To avoid confusion I am trying another title.
Comment #6
quietone commentedYea, I don't know what olivero offers, or is planning to offer about colors. But, if olivero doesn't use color any more then the patch is useless and your proposed resolution is the best we can do.
Although, /d7/MigrateColorTest.php should probably be @legacy since it does require a deprecated theme.
Comment #7
nod_#4 is correct, olivero doesn't use color. Setting NW to just skip the tests or wait it out.
Comment #8
quietone commented@nod_, Thanks for confirming that.
The test was marked @legacy in #3270936: Deprecate Color module so setting the status to works as designed. I am also adding a comment to the Issue Summary of the parent, in case anyone wonders why.