Problem/Motivation

It makes sense that when the 'All Day' checkbox is checked, the time portion of the date/time value of a Date text field is ignored. I appreciate much that a help text is shown to let the user know about this ignoration.

I feel that the current help text 'If present, the time portion of the date string will be ignored when this option is checked.' is difficult to interpret.

Steps to reproduce

  1. In a 'Manage fields' page of a content type, do the followings:
    • Label: type "Test Date"
    • Field type: select 'Date'
    • Widget: select 'Text field'
  2. Click the Save button.
  3. In the 'Field settings' page that follows, accept the default settings and click the "Save field settings" button.
  4. In the content type settings page that follows, click the fieldset 'More settings and values' to expand it.
  5. Check the checkbox 'Display all day checkbox'.
  6. Click the 'Save settings' button.
  7. Go to the add content page of the content type.
  8. The help text 'If present, the time portion of the date string will be ignored when this option is checked.' is displayed for 'All Day' checkbox of the newly created Date field.

Proposed resolution

I propose to use the statement 'When this option is checked, the time portion of the date/time value will be ignored.' as help text.

CommentFileSizeAuthor
#12 date-n3301664-12.patch682 bytesdamienmckenna

Issue fork date-3301664

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

franceslui created an issue. See original summary.

damienmckenna’s picture

Status: Needs review » Active

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier’s picture

Status: Active » Needs review
damienmckenna’s picture

Status: Needs review » Needs work

This will need to be rerolled as #3300058 was committed.

joelpittet’s picture

Status: Needs work » Needs review

Moving to Needs review to see if I can trick the test runner to pickup the new commits. 🤞

franceslui’s picture

Hi Damien,

Could you help fix the failed test issues and rerun all tests?

All immaculatexavier and I did was to replace a help text string with another string. So, we did not change the logic of any code and all tests should pass theoretically.

I appreciate your time and thank you for your support!

Frances

joelpittet’s picture

I’m attempting updating the forks 7.x-3.x branch to see if that helps…

damienmckenna’s picture

StatusFileSize
new682 bytes

In patch format.

  • DamienMcKenna committed 6ab67e2 on 7.x-3.x
    Issue #3301664 by joelpittet, immaculatexavier, DamienMcKenna,...
damienmckenna’s picture

Status: Needs review » Fixed

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.