Closed (fixed)
Project:
Geocoder
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Aug 2022 at 10:15 UTC
Updated:
15 Sep 2026 at 09:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kiseleva.t commentedComment #3
amateescu commentedThe modern replacement for
drupal_static()use-cases is a request attribute :)Comment #5
amateescu commentedPushed a commit that uses the new request attribute during workspace publishing.
Comment #6
amateescu commentedComment #7
s_leu commentedThe MR looks good to me. One consideration here: As the presave hook is so expensive, it may be worth triggering a hook/an event that allows other modules to react when the hook is fired to skip further execution?
Comment #8
alecsmrekar commentedLooks good to me as well!
Comment #9
plachLooks good to me as well :)
Comment #11
itamair commentedThanks for all this, but I had some difficulties to understand what exactly is going on here.
I particular how the attached #2 patch and the MR !60 are going to solve kind of same goals in a general way and in two different contexts of Migrate and Workspace modules.
It looks most of the folks here do belong to TAG1 and perfectly know what you are debating about and accomplishing within the Workspace module logics, isn't it?
Though it would also help some better description of what is going to be implemented here.
I mostly did and understood it myself ... digging in the the MR !60.
BUT it would be hard for a normal contributor to understand all the logics and its dependencies, also because the Workspace module is still missing basic documentation and help content.
So I feel to forward the following requests:
Thanks!
Comment #13
itamair commentedOk I better inspected all this and all makes great sense to me also.
I just added a commit on better commenting.
Going to deploy this into new incoming 8.x-4.26 Geocoder release.
Comment #15
rosk0This needs to be re-open and implemented better - it doesn't account for non-browser context and breaks normal flow when a content entity is saved from the scheduled cron job or in a Drush call.
This is what I'm getting in logs:
There is no request in set in this context.
Update: correction to the above statement - I was testing a piece of code with
drush phpwhich indeed doesn't have a request set, butdrush php:scripthas it set.Comment #16
amateescu commentedIts being fixed in #3619252: Handle scenarios without request.