Problem/Motivation
Deprecations are by design a moving target, drupal core keeps adding new deprecations as it develops, not having any deprecations means you can only support the most recent (possibly still in-development) core branch. Also, your tests keep breaking on their own. Even right now, there might already be deprecations when testing on D10 for D11.
Therefore, I recommend to not have tests fail on deprecations. Instead, flip the switch/add drupalci.yml only temporarily as a patch when adding compatibility for a new major core version or just run test against the new version (enabling deprecations is helpful to catch some non-obvious deprecations as you often get more helpful errors and can do that if your test dependencies aren't compatible yet).
Steps to reproduce
Proposed resolution
Remove drupalci.yml. Alternatively, switch the suppress deprecations flag if using an optimized configuration, but simplenews doesn't have that it seems.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | simplenews.deprecations.3301466-18.patch | 1.62 KB | adamps |
| #8 | simplenews-deprecations-3301466-8.patch | 660 bytes | berdir |
| #7 | simplenews-deprecations-3301466-7.patch | 588 bytes | berdir |
Comments
Comment #4
berdirPer #3254683: Timeout message contains invalid placeholder !cron_throttle_setting, apparently you can't test this as a patch, so I just went ahead and removed it in 3.x and 8.x-2.x.
Comment #6
berdirComment #7
berdirWeird, even committing that didn't seem to have worked. I'm restoring it and explicitly suppressing deprecations instead. Lets try that as a patch first.
Comment #8
berdirNot my day today.
Comment #11
berdirOk, that's better.
Comment #13
adamps commentedThe disadvantage of this is that apparently some D10 deprecations were never fixed.
https://www.drupal.org/node/3159568 occurs and when using D10 the warning has gone again, without any sign that the code is still "wrong". Let's remove drupalci.yml again at least temporarily to see what else it might reveal.
Comment #15
adamps commentedComment #17
adamps commentedHa - now I have a similar problem trying to make the deprecations come back again!
Comment #18
adamps commentedComment #20
adamps commentedWith #18 and after fixing #3349310: PHP 8.2 compatibility the tests seem to be working even with deprecations enabled. So perhaps we can leave the deprecations enabled for now? Or I guess we can disable again, then re-enable when testing D11 support??