Closed (fixed)
Project:
Vote Up/Down
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Jul 2022 at 11:38 UTC
Updated:
30 Jul 2026 at 04:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
akshaydalvi212 commentedHello,
Thanks for the patch,

Before applying the patch, we were facing the below errors for drupal 10 compatibilities:
After applying the patch, we still facing some errors for drupal 10 compatibilities

I m working on the same and providing a patch, which will eliminate the remaining error for drupal 10 compatibilities.
Thanks and regards
Comment #3
akshaydalvi212 commentedHello,
Providing the primarily patch, which eliminates the above-mentioned errors from
the result of the scan from the upgrade status for drupal 10 compatibilities.
The module gets installed on the drupal 10 with votingapi module

but, while using the vote up and down field in the content type the site breaks with the following error:
Hence shifting the issue status to Needs work.
Thanks and regards
Comment #4
kristen polThanks for participating in porting day!
While technically you can add custom patches to the bot issue, it's fine this has been split out and you were clear on the other issue and linked to here which is good.
Moving to needs work based on the error. And un-assigning since that was 12 hours ago. Feel free to reassign if you will be working on it further.
Comment #5
kristen polLinking the other direction too.
Comment #6
ameymudras commentedThis module requires voting api module to be compatible first before testing this module. I have fixed issue mentioned in #3 and I've uploaded a patch for the same but the module is not completely functional at the moment.
Comment #8
kristen polWorking during porting day.
@ameymudras Was the problem with the module the same as what is noted in #3?
Comment #9
sreenivasparuchuri commentedin the added patch module \Drupal::moduleHandler()->loadInclude is written in wrong way due to this vud.theme.inc not loading
Comment #11
sametyaman commentedIs there any problem in creating the below branch? I plan to commit to this branch to solve errors related to Drupal 10.
https://git.drupalcode.org/issue/vote_up_down-3300684/-/tree/10.x.1.x
@sreenivasparuchuri I used your d9 updates with cherry-picking. Thank you additionally for your contributions.
Comment #12
effortdee commentedAny update on this being stable for D10?
Comment #13
steven jones commentedWe have been using the patch in comment #9 for several years without issue.
I will note that we're using a custom VoteUpDownWidget, and thus, the ones provided by the module, which haven't really been ported to recent versions of Voting API still need porting.
Comment #16
steven jones commentedThis works well enough to get at least an alpha release out I reckon.
I've checked, and on my site, all the widgets work in some way, and it's generally doing what I want it to do.
I think the 100 users of vote up down module 8.x are going to be fine with this change I reckon.
Comment #18
marvil07 commentedThanks for the collaboration here 🙌️
There may be more thing to go, but the minimal changes are in place, closing now.