Problem/Motivation

When inserting a view with no contextual filters there are a couple of PHP warnings in the logs.

Steps to reproduce

Insert a view with no contextual filters.
Observe the following log messages:

Warning: array_filter() expects parameter 1 to be array, null given in Drupal\insert_view_adv\Form\InsertViewDialog->getClientValues() (line 371 of /app/web/modules/contrib/insert_view_adv/src/Form/InsertViewDialog.php)
Warning: implode(): Invalid arguments passed in Drupal\insert_view_adv\Form\InsertViewDialog->getClientValues() (line 376 of /app/web/modules/contrib/insert_view_adv/src/Form/InsertViewDialog.php)

CommentFileSizeAuthor
#2 insert-view-adv-php-warnings-on-views-without-contextual-filters-3300578-2.patch585 bytesericgsmith

Comments

ericgsmith created an issue. See original summary.

ericgsmith’s picture

ericgsmith commented
Status: Active » Needs review
StatusFileSize
new insert-view-adv-php-warnings-on-views-without-contextual-filters-3300578-2.patch585 bytes

Patched attached adding default value of an empty array.

  • a.dmitriiev committed 6f75ea4 on 2.0.x 
    Issue #3300578 by ericgsmith: PHP warnings when inserting a view with no...
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Fixed

Patch was added, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.