\Drupal calls should be avoided in classes using dependency injection.

Thanks for flagging this @akshaydalvi212. I posted a related issue (#3300299: Replace Static Method Calls with Dependency Injection) to standardize DI usage a bit further throughout the module and have uploaded some work there to move in that direction. Some, but not all of those should be addressed there, so there may be some overlap between these two issues.

Applayed dependence injection

Hi jsricardo,
I am reviewing your patch.
Thanks

Hi jsricardo,
Your patch applied cleanly.

Only these two issues are left to be fixed ( shown below):

FILE: ...modules\contrib\patternkit-3300226\modules\patternkit_media_library\src\Controller\PatternkitMediaLibraryController.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------
 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 39 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead

so, moving it to "Needs work".

Thanks

Thank you dipesh_goswami
I will Work on it

Fixed the two Dependency Injection warnings.
Follow new patch

i will review it.

@jsricardo Your patch #9 only has changes referring to comment #7, the changes that were made in your patch #4 were not introduced in patch #9, please add the changes from before in your next patch.

Updated patch as per #11

i will review it.

I reviewed the new patch in comment #13, and found some things to fix:
- 3 docblock without information, in the file /patternkit_media_library/src/Controller/PatternkitMediaLibraryController.php:

  /**
   *
   */
  public function __construct(MediaLibraryUiBuilder $media_library_builder) {
    $this->mediaLibraryUiBuilder = $media_library_builder

  }

  /**
   *
   */
  public static function create(ContainerInterface $containerInterface) {
    return new static(
    $container->get('media_library.ui_builder')
    );

  }

  /**
   *
   */
  public function mediaLibrary(Request $request): array {

- In the patternkit/src/Commands/PatternkitCommands.php file, the constructor's docblock is missing the @params of the classes that were added with dependency injection.
- In the patternkit/src/Commands/PatternkitCommands.php file, the create method is missing the close curly bracket.

I Will Work on it

sorry for the delay
Here is the patch with the fixes mentioned in comment #15

I'll review it.

It seems the patch needs a reroll since there were a lot of commits since this issue was open. I'll do it.

@jsricardo i could not apply your patch or reroll it. I think you applied @nitin_lama changes on a previous commit from his and it worked. But then when the maintainer commited more changes your patch broke some of them.

Example of the 2 patchs changes.
1st patch:

Your patch:

As you can see in these examples, there are things missing in your patch. Making it impossible for me to reroll it.
You need to apply @nitin_lama's to the right branch commit and then do your changes. After that the patch can be rerolled.

I took the liberty to fix the patch. Please, review it.

There are a few errors on #21
1. A closing } is missing from the PatternkitCommands::create function.
2. PatternkitCommands extends from DrushCommands, and DI for these classes should happen trough drush service yml files, and since they don't implement ContainerInjectionInterface, they don't have an overridable ::create function.
3. PatternkitMediaLibraryController extends ControllerBase, which already implements ContainerInjectionInterface. The implementation redundancy should be fixed.

Okay, i'll take another look.

I opened a MR but there seems to be a problem with Druapal.org i don't know. The MR just didn't show in this issue. https://git.drupalcode.org/issue/patternkit-3300226/-/tree/3300226-drupa...

Anyway, i applied the changes requested in #22.
Please, review it.

I will review it

I have reviewed this issue, it seems to me to be ok.
I will move to RTBC

The work here looks good, but I added some notes for a couple more minor changes before we merge it in.

I am working on it!

I applied the changes requested, please kindly review it.

Thanks for the work on this everyone! This one especially was a great community effort with numerous people working together to push it along, and I greatly appreciate it!

The work looks good and the tests are all passing, so I'm going to go ahead and merge this in.

Merged for inclusion in the Beta 6 release. Thanks everyone!