\Drupal\automatic_updates_extensions\Form\UpdaterForm::getRecommendedModuleUpdates is hard-coded to
if ($project_info['project_type'] === 'module' || $project_info['project_type'] === 'module-disabled') {
we should be looking at themes also
change to make sure theme updates are displayed.
add a test method to \Drupal\Tests\automatic_updates_extensions\Functional\UpdaterFormTest to ensure a theme with an update will show
We will need a test theme under automatic_updates_extensions/tests/theme. It can be an empty theme
we will need a new update xml file for the theme in automatic_updates_extensions/tests/fixtures/release-history
need to call \Drupal\Tests\automatic_updates_extensions\Functional\UpdaterFormTest::setProjectInstalledVersion to set the project and version
see \Drupal\Tests\automatic_updates_extensions\Functional\UpdaterFormTest::testSuccessfulUpdate for how this is set up for our existing test module
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
tedbowComment #3
rahul_ commentedComment #5
rahul_ commentedComment #6
phenaproximaI think these changes make a lot of sense and with a few changes I'd feel comfortable committing it.
One (annoying) change I'd like is to rename
breeze_theme_testto something like justtest_theme, so that we're not accidentally associating with a real-life theme in any way.Comment #7
rahul_ commentedComment #8
phenaproximaOnly one small point, to make some data provider keys clearer. Otherwise, I think this looks good and is absolutely RTBC.
Comment #9
phenaproxima*chef's kiss* I'm committing this when it passes tests.
Comment #11
phenaproximaGreat work @rahul_! Merged into 8.x-2.x.