Frontend (Olivero + Claro) - July 26 2022 Meeting in Slack

This frontend meeting is a combo meeting for the Olivero and Claro themes. This meeting takes place every Tuesday at 3pm UTC (8:30pm IST, 5pm CEST, 11am EST, 8am PST). See Time.is to see what that is in your timezone.

The meetings are held in the #frontend Slack channel on drupal.slack.com.

Update (transcript added)

Introductions (Please include your drupal.org name to make crediting easier!)
12 replies

katannshaw
mherchel
markconroy
javi-er
lauriii
cindytwilliams
bjlewis2
omkar-pd
andy-blum
thejimbirch
Tinto
AkshayAdhav

***

What agenda items would you like to discuss today?
4 replies

katannshaw
@lauriii suggested this in a previous meeting on D.O.
https://www.drupal.org/project/drupal/issues/3285205
[META] Convert test that use Bartik/Seven to Olivero/Claro

lauriii
Would be good to ask if folks have feedback on Starterkit theme https://www.drupal.org/project/drupal/issues/3209758
Starterkit theme roadmap

lauriii
Interesting proposal on https://www.drupal.org/project/drupal/issues/3296202, wondering if FE devs have thoughts
Support CSS custom properties in attachments

Tinto
The other day I came across an issue (#3293899) about the styling of form elements in the filter of a contrib module (Project Browser) and was wondering why styling is handled by the contrib module instead of the active theme and what would be the best way to change it.

More generally, how do you make sure the active theme picks up the styling of the form elements you output in your contrib module?
(Sorry if this goes beyond the scope of this meeting)

***

Any further general updates from the maintainers or product managers?
5 replies

lauriii
Mike has been making good progress on https://www.drupal.org/project/drupal/issues/3291797 which is pretty epic
Refactor Drupal 10 settings tray / off-canvas to use modern CSS

mherchel
Not really. Olivero's in a good place. I've been spending most of my core time outside of themes

lauriii
would be helpful if anyone has time to give it a spin ^

mherchel
yeah, that one is hopefully going to go in soon!

mherchel
yes!

***

Where can contributors help this week?
6 replies

katannshaw
Note: If you want your item added to a new topic thread, add a thread icon with it

mherchel
Give https://www.drupal.org/project/drupal/issues/3291797 a spin. Try to find regressions!
Refactor Drupal 10 settings tray / off-canvas to use modern CSS

mherchel
https://www.drupal.org/project/drupal/issues/3151553 is finally ready, but needs a review to get to RTBC. I'm REALLY excited about this one
Create new “Views Responsive Grid” format for Views Core

markconroy
Give https://www.drupal.org/project/drupal/issues/3291797 a spin. Try to find regressions!
Given how well it looks now in those latest screenshots from Andy Blum, I don’t want us to find regressions or it will look a lot worse than it currently does. What’s there looks super.

mherchel
Thanks :slightly_smiling_face: Yeah, it was in desperate need of improvement!

markconroy
Maybe we should rephrase the question. Rather than “can we find regressions (and put them back in)?” we ask “is this good enough for core now, and will we file follow-up issues if we find any?”

***

TOPIC 1: [META] Convert test that use Bartik/Seven to Olivero/Claro https://www.drupal.org/project/drupal/issues/3285205 (edited)
3 replies

lauriii
We’ve been making progress on a lot of subissues of that meta but still some issues outstanding in case anyone wants to help!

Tinto
I’d love to work on the ones left open, but sometimes it’s not really clear what to do/how to start. I think some of them could use some more elaborate tasks/descriptions in the issue summary. Example: https://www.drupal.org/project/drupal/issues/3280049 has
“Create a ‘test_admin_theme’ and ‘test_frontend_theme’ and use those in the tests.” :thinking_face:
Create a test admin and front end theme

lauriii
I guess the idea of that was to create test themes so that we wouldn’t have dependency on Olivero and Claro from various tests. I asked on the meta if it should be a blocker for the meta and asked some questions on the issue too.

***

TOPIC 2: Starterkit theme roadmap (feedback wanted) https://www.drupal.org/project/drupal/issues/3209758
8 replies

lauriii
Starterkit theme is available as beta experimental in Drupal 9.4.0

lauriii
I’m wondering if folks have already tried it out in action and if there is any feedback?

lauriii
Ideally we could get the starterkit theme stable by Drupal 10 and the main blocker for doing that is updating documentation

mherchel
I did a basic test, but really no feedback. That issue is kinda bare.

lauriii
if anyone wants to help with that, I can provide some pointers on how to help

mherchel
I'd really like to get an olivero-like primary menu in it

mherchel
(I'll create an issue at some point)

Tinto
I will try it out asap

***

TOPIC 3: Support CSS custom properties in attachments https://www.drupal.org/project/drupal/issues/3296202
6 replies

lauriii
Interesting proposal from Chi. Wondering if folks have thoughts on this

andy-blum
"The name drupalProperties is not ideal, since this is not a Drupal thing, it’s purely a CSS thing (see point above), so it might make sense to have a customProperties key under the css key? It’s different than what we do with JS settings but this CSS feature will not have Drupal specific code to evaluate it. On the other hand keeping that at the root might make some internal code and the whole alter pipeline easier to deal with."
Big +1 to this from nod

andy-blum
Only concern from the front end side is conflicts with any potential CSS property API we put in place.

markconroy
This looks like a great idea. I also don’t like the drupalProperties name, but can’t really think of anything better.

andy-blum
customProperties is probably the right move as that’s the official name of vars in CSS
https://developer.mozilla.org/en-US/docs/Web/CSS/--*
Custom properties (--*): CSS variables - CSS: Cascading Style Sheets | MDN

markconroy
I wouldn’t argue against that.

***

Continue the conversation in Slack. Thank you for showing up and contributing!
If you have additional questions or comments, please post them here or on the meeting agenda issue: https://www.drupal.org/project/drupal/issues/3299998