Drupal 10 Compatibility

I will work on this issue

Provided the patch for the changes mentioned in Problem/Motivation
This web/modules/contrib/superfish/superfish.libraries.yml file is not present in the directory

We're working on D10, and trying to get superfish working on a site. The previous patch did not resolve the error about calling the libraries file:

web/modules/contrib/superfish/superfish.libraries.yml:

This patch should resolve those errors and make this compatible with D10.

The attached patch applies to the 1.x-dev@dev branch.

Please test, ready for review!

@wylbur, I have tested the given patch but For D10 compatibility it needs work.

The above patch has missing fixes for libraries, so those have been resolved in this patch now. This issue needs review.

When I apply #7 patch.
Patch apply cleanly I attached some screenshot also.
It can be moved to RTBC.

Thanks

Please set this as a release. I cannot update to D10 with patches.

Please, make a release.

Patch #7 works great with D10. Please proceed to RTBC

Confirmed the patch in #7 works for me as well. Changing to RTBC.

I can also confirm patch in #7 works and I have this running on 25 production sites for well over a month and everything works as expected.

Patch #7 is working as expected.

Ignore this. Was a drush issue.

When I install patch 7, using
"patches": {

    "enable-patching": true,
     "drupal/superfish": {
           "rector patch": "https://www.drupal.org/files/issues/2023-01-18/3299991-drupal-10-compatibility-fixes-7.patch"
      }
},
"drupal-lenient": {
"allowed-list": ["drupal/superfish"]
}

I get

drush updb
 [preflight] Mapping values are not allowed in multi-line blocks at line 2 (near "<?php").

Lots of internal modules are upgraded/downgraded doing this.

This was due to an old drush link. Not a superfish issue.
Please release this already!!

Dear developers,

Please, put a release of Superfish for Drupal 10 in the repository.

I've patched my Drupal 9 version successfully with path 3299991 ( So, the Upgrade_Status is fine.), however it fails to update to Drupal version 10 since it can not be found in the repository of Drupal. Using composer update....dev-x.1.

Or is there another way to upgrade Superfish to Drupal 10.

Kind regards,

Marcel

Save a tar file of the patched module, and also one of the library as that is a dependency. Ten do a composer remove without uninstalling superfish. Then untar the files to put all the files back. That makes it all work again whilst composer knows nothing about so can try the update to drupal 10. Once the d10 version of superfish is finally released then install it via composer. That is how we've got round it.

Dear Phil,

Thanks for your quick response!

All works fine in D10, using your method for updating superfish.

I hope, an official release will be available soon.

Cheers,

Marcel

The alterations are operating smoothly on Drupal 10.1.x version and have achieved compatibility.
It would be greatly appreciated if the module maintainers could create a release for Drupal 10 of this module, as it is widely used on many websites and will be advantageous during the upgrade process from Drupal 8 or 9 to 10.

Thank you.

For those, who have problems with composer, because info file cannot be patched, you can use this configuration:

    "config": {
        "preferred-install": {
            "drupal/superfish": "source",
            "*": "auto"
        }
    },

There is a standard solution to add a module that does not have a D10 compatible release in D10 and that's the new Composer Drupal Lenient plugin. With this you can install the module and then patch it to become compatible.

@chike We appreciate you informing us about this tool.

+1 to RTBC
I tested the patch #7 on Drupal 10.0.8. Everything looks fine and works without any errors.
Would be great to have D10 release

I too would be extremely grateful for an official D10-compatible release

I tried to contact the maintainer, he has never replied. I believe the only way to get a new release to take over the maintenance

Tested #7 patch.

@LOBsTerr You are correct, the author of the module has not been active since 2020. It would be beneficial if they designated someone else as maintainers to ensure that this excellent module receives proper upkeep. I will attempt to contact the author via their contact page and hope to receive a response.

patch #8 is not working if use drupal-lenient

I tested it on Drupal 10 - it is workes well
superfish-d10-compatibility-15053339-9.patch

I will try to take it over.

If i use the patched Version fo superfish with core_version_requirement: ^8 || ^9 || ^10 in the info-file and the other changes, i get the message from composer:
drupal/superfish dev-1.x requires drupal/core ^8 || ^9 -> found drupal/core[8.0.0, ..., 8.9.20, 9.0.0, ..., 9.5.9] but it conflicts with your root composer.json require (^10.0).

How to get the patched version under composer controll in Drupal 10?

@Lissy you can use Drupal's Lenient Composer Endpoint to avoid composer version compatibility issues.

@snap_x thank you for your suggestion, I successfully installed the module on my drupal 10 instance using the Drupal' Lenient and I applied the patch #32

Patch #32 is working for me.

I have tested patch #32 on the Drupal 10 dev after installing the module and applying the Drupal Lenient plugin.

The patch in 32 does not apply with lenient to 8.x-1.x-dev. The patch in 7 does apply with lenient.

@drupgirl Yes, that is true. I have just applied patch #7 with the Lenient module. It works. Here is a copy of the composer.json I am using. I have placed the Superfish Main Navigation block in the Content region and disabled the 'normal' Main Navigation block. It works: no errors on screen or under Reports > recent error messages- with Drupal 10.0.9.

@LOBsTerr any luck becoming a maintainer of this project? I think at this point all we need is a stable release.

Sorry guys, I was a bit busy these days.
I have to follow a procedure. First I have created a ticket #3369119: Offering to maintain Superfish and if there is not response I can ask to transfer the ownership. We will have to wait a bit more

It's my second last module with incompatibility warning in upgrade status.
I would be extremely grateful for a D10-compatible release.
I'm not familiar with patching.
Thanks

I would be grateful too!
It is used in soo many sites...

Also i would be very happy about a D10-compatible release!

Thank you everyone for contribution

I want to thank everyone who worked to get this D10 version to release. Best thing to wake up to today!

Hooray! Thank you @LOBsTerr for your persistence in getting a release out!

Yippiee!!! Thanks from me. ;-)

Hi, just great, your work
It works