Problem/Motivation

theme_render_and_autoescape() is not used at runtime since theme functions were removed from core; it is only used in tests. It could also be used by contrib or custom theme engines (if any exist) but does not have any uses in contrib at present.

Steps to reproduce

Proposed resolution

Deprecate it for removal.

Remaining tasks

Decide whether it can be deprecated in 9.5.x or must wait until 10.1.x.
We missed the 9.5.x window, so it's now 10.1.x

User interface changes

API changes

Theme engines must handle escaping by themselves (Twig already handles this in TwigExtension).

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3299946-6.patch5.18 KBlongwave
#5 3299946-5.patch5.18 KBlongwave
#4 3299946-4.patch5.18 KBlongwave

Issue fork drupal-3299946

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3299946-4.patch5.18 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Needs change record
StatusFileSize
new 3299946-5.patch5.18 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3299946-6.patch5.18 KB
gaurav-mathur’s picture

gaurav-mathur commented

Applied patch #6 successfully on drupal vesrion 10.1.x
Thank you

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue tags: -Needs change record

Added draft CR and switching to MR-workflow.

spokje’s picture

spokje
Primary language Dutch
commented

@gaurav-mathur:

Applied patch #6 successfully on drupal vesrion 10.1.x

Thanks, but we already have Drupal CI in place to check if patches apply.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Needs review » Needs work

Spokje opened merge request !3285

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Change record was added
Deprecation test exists in ThemeRenderAndAutoescapeTest
Looks like a good deprecation.

  • catch committed 978a8bf8 on 10.1.x 
    Issue #3299946 by longwave, Spokje: Deprecate...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Agreed it doesn't make sense to keep this if nothing in contrib is using it.

Committed 978a8bf and pushed to 10.1.x. Thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Published the change record.

Spokje closed merge request !3285

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.