Follow-up to #2572929: Document lack of auto-escape in theme functions and add a theme autoescape helper function

Problem/Motivation

#2572929: Document lack of auto-escape in theme functions and add a theme autoescape helper function is adding a theme_escape_and_render() helper function as a BC layer to help theme functions do autoescaping. To avoid coupling the Drupal theme system to Twig, this function is separate from TwigExtension::escapeFilter(). However, since it performs most of the same functionality, it shares a lot of code.

Proposed resolution

Refactor the overlapped parts so these two functions can reuse the same code and keep them in sync.

Remaining tasks

TBD.

User interface changes

None.

API changes

Should be none; internal refactoring with a possible internal-ish API addition.

Data model changes

None.

Comments

xjm created an issue. See original summary.

dawehner’s picture

Thanks for filing the issue!

joelpittet’s picture

Status: Postponed » Active
Issue tags: +Twig
joelpittet’s picture

Version: 8.0.x-dev » 8.1.x-dev

We've hit RC so let's move this to 8.1.x

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.