Error Updating Library Content

There may be a lot more going on here than I know about, but I replaced the object syntax in src/Controller/H5PContentUpgrade.php at the spot specified by the error, with array syntax.

// Determine if any content has been skipped during the process
    $skipped = filter_input(INPUT_POST, 'skipped');
    if ($skipped !== NULL) {
      $out['skipped'] = json_decode($skipped);
      // Clean up input, only numbers
      foreach ($out['skipped'] as $i => $id) {
        $out['skipped'][$i] = intval($id);
      }
      $skipped = implode(',', $out['skipped']);
    }
    else {
      $out['skipped'] = array();
    }

I've attempted to get that into a patch, but haven't figured out how to do that quite properly yet.

That worked on my staging test to successfully upgrade 4 Interactive Book content nodes. But I don't know enough other context to be able to say that I am still achieving what this code was meant to do, or that I didn't introduce any other problems.

Tried this patch file, it doesn't work.

Thank you for looking at this sokru. To have the upgrade button, you need to have some content of that type to be upgraded. For example, in ours right now we have 110 Interactive Video nodes of version 1.22.14, while there is a version 1.24 available. Which means in practice it might take some time to generate it on a new site, as you'd have to create the content, wait for a newer version of that H5P type to be available, then come back.

I'm feeling pretty good about my fix, other than my failure to generate a patch file that works. Tracing through the code:

$out is declared as an array, not an object (line 93 in H5PContentUpgrade.php):

    // Prepare response
    $out = [
      'params' => [],
      'token' => \H5PCore::createToken('contentupgrade'),
    ];

But then farther down, it is using syntax as if $out was an object instead (line 134 in H5PContentUpgrade.php):

    // Determine if any content has been skipped during the process
    $skipped = filter_input(INPUT_POST, 'skipped');
    if ($skipped !== NULL) {
      $out->skipped = json_decode($skipped);
      // Clean up input, only numbers
      foreach ($out->skipped as $i => $id) {
        $out->skipped[$i] = intval($id);
      }
      $skipped = implode(',', $out->skipped);
    }
    else {
      $out->skipped = array();
    }

Changing that section to treat $out as the array it is seems to work in my tests so far:

    // Determine if any content has been skipped during the process
    $skipped = filter_input(INPUT_POST, 'skipped');
    if ($skipped !== NULL) {
      $out['skipped'] = json_decode($skipped);
      // Clean up input, only numbers
      foreach ($out['skipped'] as $i => $id) {
        $out['skipped'][$i] = intval($id);
      }
      $skipped = implode(',', $out['skipped']);
    }
    else {
      $out['skipped'] = array();
    }

It's possible there's something else elsewhere that breaks down with this change, but I don't see $out->skipped or $out['skipped'] being used again - it gets imploded into the $skipped variable and that is what gets used the rest of the way. I don't think I have any content being skipped to be able to test that.

New patch file: I think this one worked to deploy over composer to a server.

Updated to reflect that this is still an issue in alpha3 and that the patch still works on alpha3. It would be great to have this and several other patches here (Drupal 10 and PHP 8.1 compatibility) put into a release.

Bad news: this one appears to have not gotten included in the recent wave of integrated patches to the dev branch including D10 support.

Good news: the patch still applied fine for me against the newly-updated dev branch, so other changes needed here.