Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#13 Edit-tip-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-10.png186.63 KBrajab natshah
#13 Edit-tour-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-10.png297.83 KBrajab natshah
#13 Tours-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-10.png132.96 KBrajab natshah
#13 Drupal-10-upgrade-status-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-9.png68.73 KBrajab natshah
#13 Real-physical-testing-round-for-tour_ui-1-0-x-dev--with-d10-and-d9.zip2.17 KBrajab natshah
#5 tour_ui.1.x-dev.rector.patch8.59 KBproject update bot
#5 interdiff-last-bot.6664323.txt310 bytesproject update bot
#4 After patch TU.png54.82 KBAamir M
#4 Before patch TU.png60.73 KBAamir M
#4 Patch TU.png106.95 KBAamir M
#2 tour_ui.1.x-dev.rector.patch8.38 KBproject update bot

Issue fork tour_ui-3299337

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 8.x-1.x Comparecompare
  • 3299337-automated-drupal-10 Comparecompare
About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new tour_ui.1.x-dev.rector.patch8.38 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Aamir M’s picture

Aamir M commented
Assigned: Unassigned » Aamir M
Issue summary: View changes
Aamir M’s picture

Aamir M commented
Assigned: Aamir M » Unassigned
StatusFileSize
new Patch TU.png106.95 KB
new Before patch TU.png60.73 KB
new After patch TU.png54.82 KB

Verified patch #2 on Drupal 10.0.x and 10.1.x. Patch applied successfully and looks good to me.

Testing Steps:

1. Install drupal 10.0.x and 10.1.x version
2. Install the Tour UI module (8.x-1.x) version and save it in the Module folder
(https://www.drupal.org/project/tour_ui/git-instructions)
3. Open drupal 10 or 10.1 and click on Extend
4. Check the Tour UI module which unable to install
5. Now apply the patch (Where the Tour UI module was saved i.e Module folder)
6. Reload the page and again check the Tour UI module (Note: Clear all caches if required)
7. Now this module is enabled and also install successfully

The module can be installed after applying the patch.
Can be moved to RTBC
RTBC+1

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6664323.txt310 bytes
new tour_ui.1.x-dev.rector.patch8.59 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

  • clemens.tolboom committed 31a142a on 8.x-1.x 
    Issue #3299337 by Project Update Bot: Automated Drupal 10 compatibility...
rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Clemens, for having time to maintain the Tour UI important module.

Hoping for a soft tag release, or a pre-release tag. To ease with testing with Drupal 10
Testing now with the 1.x-dev development branch.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Major » Critical
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Real-physical-testing-round-for-tour_ui-1-0-x-dev--with-d10-and-d9.zip2.17 KB
new Drupal-10-upgrade-status-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-9.png68.73 KB
new Tours-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-10.png132.96 KB
new Edit-tour-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-10.png297.83 KB
new Edit-tip-Tour-UI-1-0-x-dev-Real-physical-testing-with-Drupal-10.png186.63 KB

Had Real physical testing round for Tour UI 1.0.x-dev with Drupal ~10 and Drupal ~9

Attached the full list of commands
Real-physical-testing-round-for-tour_ui-1-0-x-dev--with-d10-and-d9.zip

Tour UI 1.0.x-dev with Drupal ~10 - Upgrade Status

Tour UI 1.0.x-dev with Drupal ~10

mkdir -p /var/www/html/sandboxes
composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10tour_ui_1__test
cd /var/www/html/sandboxes/drupal10tour_ui_1__test/
composer require drush/drush:~11.0;

Change minimum stability to dev for testing on the recommended Drupal 10 project template

composer config minimum-stability dev

Add the Tour UI module

composer require 'drupal/tour_ui:1.x-dev@dev'

Change file/directory mod and ownership of files:

cd /var/www/html/sandboxes/drupal10tour_ui_1__test/
sudo chmod 775 -R .;sudo chown www-data:$USER -R .;

Install with Drush

./vendor/drush/drush/drush site:install standard --yes --site-name="Tour UI 1.0.x-dev - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10tour_ui_1__test" -vvv ;

./vendor/drush/drush/drush pm:enable tour_ui

Rebuild the cache:

sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
./vendor/drush/drush/drush cache:rebuild

Open a browser and change the address to: http://localhost/sandboxes/drupal10tour_ui_1__test/web/admin/config/user-interface/tour

Tested to add/view/edit/ and save tours

rajab natshah’s picture

rajab natshah
he/him
commented

Tested, Ready for a release.

rajab natshah’s picture

rajab natshah
he/him
commented

urvashi_vora made their first commit to this issue’s fork.

rajab natshah’s picture

rajab natshah
he/him
commented

Tested the dev version. Good to release.

zenimagine’s picture

zenimagine commented

+1

rajab natshah’s picture

rajab natshah
he/him
commented
sdsheridan’s picture

sdsheridan
he/him/his
commented

Tested here as well. Seems to be working fine.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

This (automatic) issue is somehow hijacked ... I agree we could use a tag but that should be on its own issue right?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Maybe suggest what to do with #3269093: Create semantic version 2.0 for D9 then tag on that new branch?

BenStallings made their first commit to this issue’s fork.

rajab natshah’s picture

rajab natshah
he/him
commented

Hoping for an 8.x-1.0-rc2 tag release.
#3269093: Create semantic version 2.0 for D9
I agree too, It would be better to:

  • Keep the 8.x-1.x branch for Works with Drupal: ^8 || ^9 || ^10, Maybe Works with Drupal: ^8 || ^9
  • Have a new 2.0.x branch for Works with Drupal: ^9 || ^10 only to drop any support for D8 in the new branch
bob.hinrichs’s picture

bob.hinrichs commented

This is a nice module. Looking forward to a D10 release soon.

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Seems the D10 stuff was merged.

So don't see anything left to do here. Will release 2.0.0 here soon.

rajab natshah’s picture

rajab natshah
he/him
commented

Thank you, Stephen !!

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

TNX

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.