Problem/Motivation

jquery.cookie is deprecated and will be removed in Drupal 10. Need to update js code for Drupal 10 compatibility.

Proposed resolution

See https://www.drupal.org/node/3104677

Remaining tasks

Update:
/js/quicktabs.js
quicktabs.libraries.yml

Issue fork quicktabs-3298649

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shelane created an issue. See original summary.

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier opened merge request !3

immaculatexavier’s picture

immaculatexavier commented

Replaced jquery.cookie with js-cookie in quicktabls.libraries.yml.
Yet to update in /js/quicktabs.js

shelane’s picture

shelane
Primary language English
commented
Issue summary: View changes
shelane’s picture

shelane
Primary language English
commented
Status: Active » Needs work
loze’s picture

loze commented
Category: Task » Bug report

The latest release 8.x-3.0-alpha6 changed the library but is still using jquery cookie in quicktabs.js which is causing an error.

I also have a patch in #3189439: Last clicked tab history should be configurable that makes this behavior optional per QT instance which needs to be updated.

I will provide a patch that addresses both.

loze’s picture

loze commented
Status: Needs work » Needs review
Related issues: +#3189439: Last clicked tab history should be configurable

I've updated #3189439: Last clicked tab history should be configurable with a new patch that fixes this. It uses js-cookie in quicktabs.js and also adds a config setting to enable the feature per QT instance.

Thanks

shelane’s picture

shelane
Primary language English
commented

I would rather keep the issues separate and not have one patch for two things. Please post a patch or an MR for the us cookie fix here and I will review.

shelane closed merge request !3

nelo_drup’s picture

nelo_drup commented

Sorry to reopen the problem but is there any update on this I have the same error in drupal 9.4.11
Uncaught TypeError: $.cookie is not a function
at HTMLAnchorElement. (:140:32)

niklp’s picture

niklp commented

Patch at https://www.drupal.org/project/quicktabs/issues/3189439#comment-14958818 fixes the "Uncaught TypeError: $.cookie is not a function" error.

nelo_drup’s picture

nelo_drup commented

#12 thanks for answer yes i tried the patch and it works fine

keshavv’s picture

keshavv commented
Status: Needs review » Postponed

Issue already fixed on 8.x-3.x Branch

smustgrave’s picture

smustgrave commented
Version: 8.x-3.x-dev » 4.0.x-dev
Status: Postponed » Closed (duplicate)

Actually pushed to 4.0.x branch so we could drop D9 support, but correct it's been done.