Problem/Motivation

When switching to PHP8, I got following issues:

Line   src/modules/contrib/taxonomy_menu/taxonomy_menu.module                              

 ------ ------------------------------------------------------------------------------------ 

  482    Deprecated in PHP 8.0: Required parameter $node follows optional parameter $terms.  

  816    Deprecated in PHP 8.0: Required parameter $node follows optional parameter $args.

Proposed resolution

Update parameters in function declaration.

Issue fork taxonomy_menu-3298593

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yurikulinkovich created an issue. See original summary.

yurikulinkovich opened merge request !6

yurikulinkovich’s picture

yurikulinkovich commented
Assigned: yurikulinkovich » Unassigned
Status: Active » Needs review
alina.basarabeanu’s picture

alina.basarabeanu commented

Changes works on Drupal core 7.91, PHP 8.0.21 and Taxonomy menu 7.x-1.6 version
Thank you

bserem’s picture

bserem commented
Status: Needs review » Reviewed & tested by the community

Setting to RTBC. With php7 going EOL soon this should ideally be part of an upcoming release.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
Priority: Normal » Major

RTBC++

Upgrading the priority to Major so a new release can be created, since lots of sites will start shifting to PHP 8.1 now that older versions are EOL.

poker10’s picture

poker10 commented
Parent issue: » #3261307: Plan for Taxonomy Menu 7.x-1.7
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Major » Normal
Issue tags: +PHP 8.0
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

  • DamienMcKenna committed 19215824 on 7.x-1.x 
    Issue #3298593 by yurikulinkovich, Alina Basarabeanu, DamienMcKenna:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.