Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | pdf_reader.1.x-dev.rector.patch | 1.99 KB | project update bot |
| #16 | interdiff-last-bot.6659487.txt | 2.75 KB | project update bot |
| #14 | pdf_reader-d10_compatibility-3297843-14.patch | 6.65 KB | sinn |
| #2 | pdf_reader.1.x-dev.rector.patch | 1.99 KB | project update bot |
Issue fork pdf_reader-3297843
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
chaubeyji commentedI have tested the patch, it is working fine.
Comment #4
mmjvb commented@chaubeyji Your contribution is considered of no value. See https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...
In particular no 1 and 10 of the don't do list.
Yet another reason not to RTBC. This is an automated fix!
Set back to Active in order to receive more from the bot.
Comment #5
chaubeyji commentedSorry and thank you @mmjvb.
I'll keep it in mind.
Comment #6
mmjvb commentedThe bot provided fixes almost literally described in:
https://www.drupal.org/node/2940031
https://www.drupal.org/node/2940438
Please report whether you tested scenario's that involve the url and location of the module. That is what the bot asks to be tested.
Can you confirm it finds the module location correctly and whether the url is correct?
It is not clear what you mean by saying the patch works.
Comment #7
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #8
tjtj commentedSo please issue a D10 build already. It is 4 months!
Comment #9
penyaskitoPlease detail which tests you have done with D10, and that might help accelerate getting that release done.
Remember that this project is run by volunteers and there's absolutely no obligation to match our timelines with yours.
Comment #12
sinn commentedMR with fix is ready. Please review.
Comment #13
sinn commentedComment #14
sinn commentedChanges from merge request as a patch are attached.
Comment #15
hemangi.gokhaleI tested the given patch at #14 on D10.0.7 and it got applied successfully. I tested it using
Using: Direct Embedin the display mode, and this looks fine. Marking this as RTBC.Comment #16
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
Therefore this patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #17
tjtj commentedPlease release the D10 version!
Comment #18
webengr commentedGetting close to end of life for drupal 8-9.... please roll a dev version, upgrade status says this is the last module one of my websites needs to do to upgrade.
Comment #19
Holka_a commentedCan we kindly have D10 compatible version release.
Comment #20
mahesh bandhiya commentedAny update on the Drupal 10 compatible version release?
Comment #21
penyaskitoAdded a commit to the MR for adding basic compatibility with olivero (it looked pretty bad).
This shouldn't break people themes, but you need to pay attention when upgrading. Also, did minimal testing for this, but I'm releasing this anyway. We can iterate later. Thanks all for the contributions and the patience.
Comment #23
penyaskitoThis will be in dev, but won't tag a release as d.org gitlab is facing some issues today.
Please, if you can, test the dev release so we can figure out any issue before tagging.
Re-opening so I don't forget to make the actual release.
Comment #24
penyaskitoFixed! https://www.drupal.org/project/pdf_reader/releases/8.x-1.1