Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #34 | 3297814-34.patch | 693 bytes | oriol masjuan |
| #23 | interdiff3297814-10-23.txt | 693 bytes | himanshu5050 |
| #23 | 3297814-23.patch | 18.66 KB | himanshu5050 |
| #10 | 3297814-10.patch | 17.98 KB | jeroent |
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #5
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #6
rajab natshahComment #7
rajab natshahThank you, for having time to maintain this important multilingual support module.
Hoping for a soft commit on the
8.x-1.xbranch, to ease testing with Drupal 10Testing now with
git clone --branch '8.x-1.x' https://git.drupalcode.org/project/paragraphs_asymmetric_translation_widgets.gitAnd git apply the patch
Comment #8
jeroentWhen applying the patch in #4 and running drupal-check I get the following errors:
Comment #9
jeroentComment #10
jeroentThis patch should fix all found issues:
Comment #11
rajab natshahComment #12
rajab natshahComment #13
rajab natshahComment #15
realityloop commentedI added the patch to an issue branch, as well as updating the composer.json file so that I could use it in composer without the need for the patch, allowing me to upgrade to Drupal 10.
The following (or similar) is required in your projects composer.json:
Then add the module using:
composer require drupal/paragraphs_asymmetric_translation_widgets:dev-3297814-automated-drupal-10I hope this is helpful to others.
Comment #18
rajab natshahComment #19
rajab natshahComment #20
rajab natshahTested #10 patch. Good to release.
Comment #21
himanshu5050 commentedEntity queries must explicitly set for access check in Drupal 10. Failing at paragraphs_asymmetric_translation_widgets_entity_translation_delete
Drupal\Core\Entity\EntityStorageException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck().
Comment #22
himanshu5050 commentedComment #23
himanshu5050 commentedupdated patch at #10 to fix access check issue.
Comment #24
himanshu5050 commentedComment #26
merilainen commentedLooks good to me, after patching Upgrade status saysNo problems found.
I will mark this as RTBC as the changes are simple replacements which Drupal Rector could do.
Comment #27
rajab natshahHoping for a soft commit/tag release.
Comment #28
rajab natshah#3353409: Offering to co-maintain Paragraphs asymmetric translation widgets
Comment #30
rajab natshahComment #31
rajab natshahRelease note
Comment #32
rajab natshahThank you everyone.
✅ Released Paragraphs asymmetric translation widgets 8.x-1.2
Comment #34
oriol masjuan commentedHi everybody,
I am still having the same issue with Drupal 10 about the accessCheck error. When deleting translation content I get this error:
Drupal\Core\Entity\EntityStorageException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 112)
paragraphs_asymmetric_translation_widgets_entity_translation_delete(Object)
call_user_func_array(Object, Array) (Line: 409)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'paragraphs_asymmetric_translation_widgets') (Line: 388)...
It seems that Paragraphs asymmetric translation widgets 8.x-1.2 and 8.x-dev haven't got the Patch #23.
Adding the line ->accessCheck(TRUE) the problem doesn't appear anymore.
I created a patch to apply to version 8.x-1.2 to solve temporally the problem. This patch only adds line ->accessCheck(TRUE)
Comment #35
rajab natshahThanks, oriol for reporting
Please, file a new issue for this bug.
To be fixed for sure.