Automated Drupal 10 compatibility fixes [#3296590]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

You can use Drupal Rector yourself to make these patches.

If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the patch in the comment by Project Update Bot.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Comment	File	Size	Author
#8	Drupal10-3296590-8.patch	2.15 KB	nishant
#5	Automateddrupal-3296590-5.patch	498 bytes	nishant
#3	audio-embed-field-3296590-3.patch	4.01 KB	yogeshsevak
#2	audio_embed_field.2.x-dev.rector.patch	1.88 KB	project update bot

Comments

Comment #1

18 July 2022 at 11:28

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 18 July 2022 at 11:28

Status:

Active

» Needs review

Status	File	Size
new	audio_embed_field.2.x-dev.rector.patch	1.88 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.24
palantirnet/drupal-rector: 0.13.0

Comment #3

yogeshsevak commented 12 June 2023 at 10:02

Issue summary:

View changes

Status	File	Size
new	audio-embed-field-3296590-3.patch	4.01 KB

Providing updated patch with fixes. Please review.

Comment #4

Bushra Shaikh commented 13 June 2023 at 08:16

I applied patch #3, got error:

 ------ ---------------------------------------------------------------------
  Line   modules\audio_embed_media\audio_embed_media.install
 ------ ---------------------------------------------------------------------
  15     Function media_entity_copy_icons not found.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ---------------------------------------------------------------------

 ------ ---------------------------------------------------------------------
  Line   modules\audio_embed_media\audio_embed_media.module
 ------ ---------------------------------------------------------------------
  14     Parameter $media_bundle of function
         audio_embed_media_media_bundle_insert() has invalid type
         Drupal\media_entity\Entity\MediaBundle.
  15     Access to property $type on an unknown class
         Drupal\media_entity\Entity\MediaBundle.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
  15     Call to method getTypeConfiguration() on an unknown class
         Drupal\media_entity\Entity\MediaBundle.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
  15     Call to method isSyncing() on an unknown class
         Drupal\media_entity\Entity\MediaBundle.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
  16     Call to method id() on an unknown class
         Drupal\media_entity\Entity\MediaBundle.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ---------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------
  Line   modules\audio_embed_media\src\Plugin\MediaEntity\Type\AudioEmbedField.php
 ------ ----------------------------------------------------------------------------------------
  26     Class
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField
         extends unknown class Drupal\media_entity\MediaTypeBase.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
  53     Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::__construct()
         calls parent::__construct() but
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField does
         not extend any class.
  77     Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::thumbnail()
         has invalid type Drupal\media_entity\MediaInterface.
  94     Access to an undefined property
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::$entityFieldManager.
         � Learn more:
            https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
  94     Call to an undefined method
         Drupal\Core\Form\FormInterface::getEntity().
  118    Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::getField()
         has invalid type Drupal\media_entity\MediaInterface.
  154    Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::getDefaultName()
         has invalid type Drupal\media_entity\MediaInterface.
  167    Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::loadProvider()
         has invalid type Drupal\media_entity\MediaInterface.
  167    Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::loadProvider()
         has invalid type Drupal\media_entity\MediaInterface.
  181    Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::getAudioUrl()
         has invalid type Drupal\media_entity\MediaInterface.
  181    Parameter $media of method
         Drupal\audio_embed_media\Plugin\MediaEntity\Type\AudioEmbedField::getAudioUrl()
         has invalid type Drupal\media_entity\MediaInterface.
 ------ ----------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------
  Line   src\Plugin\Field\FieldFormatter\Colorbox.php
 ------ ------------------------------------------------------------------------------------
  46     Property
         Drupal\audio_embed_field\Plugin\Field\FieldFormatter\Colorbox::$colorboxAttachment
         has unknown class Drupal\colorbox\ElementAttachmentInterface as its
         type.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
  81     Parameter $colorbox_attachment of method
         Drupal\audio_embed_field\Plugin\Field\FieldFormatter\Colorbox::__construct()
         has invalid type Drupal\colorbox\ElementAttachmentInterface.
  122    Call to method attach() on an unknown class
         Drupal\colorbox\ElementAttachmentInterface.
         � Learn more at https://phpstan.org/user-guide/discovering-symbols
  169    Call to an undefined method
         Drupal\Core\Field\FormatterInterface::calculateDependencies().
  169    Call to an undefined method
         Drupal\Core\Field\FormatterInterface::calculateDependencies().
 ------ ------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------
  Line   src\Plugin\Field\FieldFormatter\Thumbnail.php
 ------ ----------------------------------------------------------------
  187    Call to an undefined method
         Drupal\Core\Entity\EntityStorageInterface::getReplacementId().
 ------ ----------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src\ProviderManager.php
 ------ ----------------------------------------------------------------------
  18     Constructor of class Drupal\audio_embed_field\ProviderManager has an
         unused parameter $cache_backend.
 ------ ----------------------------------------------------------------------