Closed (fixed)
Project:
Drupal core
Version:
9.3.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Jul 2022 at 07:17 UTC
Updated:
18 Aug 2022 at 14:44 UTC
Jump to comment: Most recent
Comments
Comment #3
kostyashupenkoComment #4
nod_works for me, no changes to built files.
Comment #7
xjmConfirmed that the lock file matches what I get when I do the update myself, and that there are no changes to built assets as a result of the update.
Committed to 10.1.x and 10.0.x. Thanks!
We also need versions of this for 9.5.x, 9.4.x, and 9.3.x.
Comment #17
xjmOpened MRs for 9.5.x, 9.4.x, and 9.3.x.
Comment #22
xjmActually I discovered that there are changes to the jQuery UI assets that were missing from the patch. These are separate changes from the jQuery UI 1.13.2 update, but are necessary since the update. Basically, the webpack update is changing how they're packaged.
I reverted the previous commit, then reopened the 10.0.x MR and pushed a commit that rebuilds the assets.
Comment #23
nod_ran the commands and ended up with the same patches.
Opened related issue to avoid what happened here.
Comment #24
lauriiiWe need to rebase all MRs now that #3300040: Update jQuery UI to the latest versions is done.
Comment #25
nod_Btw the policy as laid out in #3280275: Set up a formal process for ensuring JavaScript dependencies remain up to date would not have caught this problem
#3301712: Add vendor-update command to the build command for JS assets allows us to fix this without changing the policy or our habits.
Comment #28
xjmForce-pushed updated branches (I just rebuilt them on the branch tip, rather than rebasing, since the assets probably differ.)
Comment #29
nod_ran the commands on the 4 branches and got the same patch. All good for me.
Comment #39
lauriiiConfirmed that I get locally the same changes and all looked good. Committed all MRs to their respective branches.