Problem/Motivation

To prevent issues with vendor assets when updating things like terser, add the vendor-update to the build command.

See #3296481-32: Update terser and terser-webpack-plugin to the latest versions

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 core-3301712-2.patch544 bytesnod_

Comments

nod_ created an issue. See original summary.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Active » Needs review
StatusFileSize
new core-3301712-2.patch544 bytes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs frontend framework manager review, +Needs JavaScript review, +JavaScript

I can't sign off on this, but I think it's a great idea.

OTOH we've said we're removing the build step. Are we just removing it for core's own assets, and continuing to use it integrated with all the nice tools for our dependencies?

nod_’s picture

nod_
Primary language French
Location Lille
commented

Yep, we'll still need the build step for ckeditor plugins, and project browser down the line.

It'll be removed for most of the core JS though, and that will make contributing a bit simpler :)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: -Needs JavaScript review

I'll take care of that :)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

That adds a step to build that I (and several others) have forgotten to do. It doesn't introduce any problems, just performs an easy to forget step, so lets RTBC.

  • lauriii committed 3ccc7d0 on 10.1.x 
    Issue #3301712 by nod_, xjm, bnjmnm: Add vendor-update command to the...

  • lauriii committed ee0abc0 on 10.0.x 
    Issue #3301712 by nod_, xjm, bnjmnm: Add vendor-update command to the...

  • lauriii committed ae14ca0 on 9.5.x 
    Issue #3301712 by nod_, xjm, bnjmnm: Add vendor-update command to the...

  • lauriii committed 410f480 on 9.4.x 
    Issue #3301712 by nod_, xjm, bnjmnm: Add vendor-update command to the...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 10.1.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs frontend framework manager review

Committed 3ccc7d0 and pushed to 10.1.x. Cherry-picked to 10.0.x, 9.5.x. and 9.4.x to keep the branches in sync. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.