Multi-line function declarations must define one parameter per line

CommentFileSizeAuthor
#7 patch-applied.png42.19 KBurvashi_vora
#4 coding-standard-3296124-#4.patch1.82 KBsharayurajput

Issue fork flag-3296124

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sharayurajput created an issue. See original summary.

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput

Will work on this issue

sharayurajput’s picture

sharayurajput commented
StatusFileSize
new coding-standard-3296124-#4.patch1.82 KB
sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Active » Needs review
urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,

I will review this patch.

Thanks

urvashi_vora’s picture

urvashi_vora commented
StatusFileSize
new patch-applied.png42.19 KB

Hi @sharayurajput,

Your patch was applied cleanly.

Thanks

urvashi_vora’s picture

urvashi_vora commented
Status: Needs review » Needs work

It has fixed all the issues.

Moving it to RTBC.

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Reviewed & tested by the community
ivnish’s picture

ivnish
he/him
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs reroll to MR

chandansha made their first commit to this issue’s fork.

chandansha opened merge request !91

chandansha’s picture

chandansha commented
Status: Needs work » Needs review

I have created MR.
Please review once.
Thanks!!

  • ivnish committed 19dcb18d on 8.x-4.x authored by chandansha 
    issue #3296124: Fix coding standard - Multi-line function declarations...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed
Issue tags: -Needs reroll

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.