mysql_requirements() assumes it's used for the default connection

RTBC if TestBot agrees, and Yay! to less murky worlds in general and specifically for update path tests.

1. We already saw this patch pass tests at #3292008-39: [Ignore] In space (and/or this issue), no one can hear patches scream III, vs the fail in #38.
2. The change is trivially small, and does exactly what it needs to.
3. In Slack, we agreed this doesn't need its own dedicated tests.
4. This doesn't seem like the kind of bug that needs a CR or a release note.

Perhaps premature, but I'm going to RTBC, anyway. I know no committer would actually commit this until this bot comes back green, and it can prove me wrong and NW if it has to... 😉

Thanks!

Hah, whoops. ;) Thanks!

+++ b/core/modules/mysql/mysql.install
@@ -17,6 +17,10 @@ function mysql_requirements($phase) {
+      if ($connection->driver() !== 'mysql') {

Maybe overkill, but I would suggest

      if (!($connection->driver() === 'mysql' && $connection->getProvider() === 'mysql')) {

so we ensure we only execute for the mysql driver provided by the mysql module? (other modules, even installed, may provide a driver named mysql)

If we wanna go backport to 9.4.x, looks like we're gonna need a separate patch for it.

Sqlite and PgSql do not have a hook_requirements() implementation so this looks fine to me, thanks

Just did a little git archeology. There is no mysql_requirements() in 9.4.x. That was introduced in #2733675: Warning when mysql is not set to READ-COMMITTED, which wasn't backported to 9.4.x. The earliest core with this bug is 9.5.x. Therefore, bumping the version, and ignoring the fact that #8 doesn't apply to 9.4.x...

Thanks,
-Derek

p.s. Also saving credit for all the reviews here.

I didn't understand this issue at first, but after reading the whole hook, this is clearly a bug that it displays its warnings on other drivers. With the information in #10, I agree that the scope is complete here.

Thanks @dww also for the archaeology on why it didn't work on 9.4.x.

Committed to 10.1.x and cherry-picked to 10.0.x and 9.5.x. Thanks!