$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ds_chains/

FILE: C:\Users\SI-001\Downloads\ds_chains\src\ChainsUi.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
113 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\ds_chains\src\Plugin\DsField\ChainedField.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
110 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#6 drupal_coding_standard-3295464-6.patch5.4 KBatul_ghate
#2 t-calls-should-be-avoided-3295464-2.patch2.33 KBrakhi soni

Comments

Rakhi Soni created an issue. See original summary.

rakhi soni’s picture

rakhi soni commented
Assigned: rakhi soni » Unassigned
Status: Active » Needs review
StatusFileSize
new t-calls-should-be-avoided-3295464-2.patch2.33 KB

Kindly review patch,,

atul_ghate’s picture

atul_ghate commented

Hi,
I will review this patch

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate
atul_ghate’s picture

atul_ghate commented

Hi,
your patch has resloved all above mentioned coding standard issues but there are still some remains , will work on that and will provide patch for the same

atul_ghate’s picture

atul_ghate commented
StatusFileSize
new drupal_coding_standard-3295464-6.patch5.4 KB

Hello,
providing a patch , please review.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned

  • larowlan committed 665d2d9 on 8.x-1.x authored by atul ghate 
    Issue #3295464 by atul ghate, Rakhi Soni: t() calls should be avoided in...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Fixed

Thanks folks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.