Cookies overlay message should be defined in the cookies service itself

Thanks @Grevil, indeed I think a custom summary text would help here and if entered, should be shown instead of the default text in the cookiesOverlay. The cookiesOverlay should get the text based on the service name (pull).

Before implementing this, we should be sure about the label / naming and if the text should also be shown in the cookie layer for the given service, not to clash with the "Documentation" text.

Also we should wait until #3225243: Add cookies input filter for blocking iframes and other relevant external embeds and scripts is finally committed.

As #3225243: Add cookies input filter for blocking iframes and other relevant external embeds and scripts was added, this probably should be unblocked now.

IMHO the most important thing is to not use the machine name for the cookies overlay message. Currently I get "This content is blocked because Embedded_content cookies have not been accepted." with the button text "Only accept Embedded_content cookies". It will look much better if at least the human name/label is used instead of ucfirst(serviceName).

Hi @Grevil @Anybody
Please check the MR attached, provided implementation allows to:
- configure placeholder text (top, "accept all" button and bottom text)
- it force usage of service labels in the placeholder instead of machine name

Placeholder texts configured in the global form, I think having it on the service level will be an overkill.
Having it configurable you can prepare a text to match any service.

If we really need the ability to have it on the service level - I would say we should keep the global one and allow users per-service override
Maybe we should keep it as a separate issue for later, so we can merge the current implementation.

Hi again, updated MR with functionality to override placeholder text per-service with fallback to the default configuration text.

@gilmord tests are failing.

Could you please add screenshots what's the actual / planned result? As there are multiple services, I don't really get your idea here.

Hi @Anybody, here is what was done in the MR:

Part 1: use the service name instead of the machine name in the placeholder.
We have a service with the label "Some nice Video service label" and with the machine name "video"

Before this patch the placeholder looks like this (capitalized machine name):

With the patch (the label is used):

Part 2: allow to override of the placeholder texts
The functionality in the merge requests provides two ways to override the text for the placeholder.

Option 1: global settings on the /admin/config/cookies/texts page:

Option 2: each service can override the text for the placeholder:

All the data (texts and labels) passed as drupalSettings:

@Anybody I will check the tests results, probably the tests have to be updated with this functionality.

@Anybody I missed adding changes to the cookies.texts schema, added it and tests passed now.

Thank you @gilmord, we'll have a closer look asap at the logics and code!

Let's solve this for 2.x together with the other service changes.

Fits in there very well!

@Grevil this will need your work as part of #3324484: [1.2.x] Revamp templates and add "Disclaimer" dialog text field for cookie details, I guess.