FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\content_hub_tree.install
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\content_hub_tree.module
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\css\content-tree.css
-----------------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 16 LINES
-----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\README.md
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 98 characters
12 | WARNING | Line exceeds 80 characters; contains 81 characters
------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\src\Form\MenuContentTreeForm.php
-----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
-----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
104 | ERROR | [ ] Missing parameter comment
105 | ERROR | [ ] Missing parameter comment
156 | ERROR | [ ] Missing parameter comment
157 | ERROR | [ ] Missing parameter comment
159 | ERROR | [ ] Description for the @return value is missing
248 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
305 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
313 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
359 | WARNING | [x] A comma should follow the last multiline array item. Found: )
393 | ERROR | [ ] Type hint "array" missing for $tree
408 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\src\HelperService.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
31 | ERROR | [x] Expected "\Drupal\views\ViewExecutable|null|false" but found "\Drupal\views\ViewExecutable|NULL|FALSE" for @var tag in member variable comment
52 | ERROR | [ ] Missing parameter comment
104 | ERROR | [ ] Missing parameter comment
105 | ERROR | [ ] Missing parameter comment
106 | ERROR | [ ] Missing parameter comment
108 | ERROR | [ ] Description for the @return value is missing
123 | ERROR | [ ] Description for the @return value is missing
139 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\content_hub_tree\src\Plugin\Derivative\ContentTreeLocalTask.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#8 interdiff_5-8.txt334 bytesmrinalini9
#8 phpcs-drupal-coding-standard-new-3294887-8.patch7.87 KBmrinalini9
#5 phpcs-drupal-coding-standard-new-3294887-5.patch7.47 KBHarsh panchal
#2 phpcs-drupal-standard-coding-3294887-2.patch7.24 KBHarsh panchal

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal commented
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new phpcs-drupal-standard-coding-3294887-2.patch7.24 KB

I have fixed this issue and providing a patch.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Novice

The given patch resolve most of the PHPCS issue. Still there are minor issues need to be address.

FILE: /Users/arunkumar/Contribution/content_hub_tree/js/content-tree-collapse.js
------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------
 28 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 4 empty lines
 30 | ERROR | [ ] More than 2 empty lines are not allowed
 31 | ERROR | [ ] More than 2 empty lines are not allowed
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Time: 148ms; Memory: 12MB

Also getting below warning message:

arunkumar@C02GC0T5ML7H content_hub_tree % git apply phpcs-drupal-standard-coding-3294887-2.patch 
phpcs-drupal-standard-coding-3294887-2.patch:18: trailing whitespace.
 * To enable content thee hub for some menu
Harsh panchal’s picture

Harsh panchal commented
Assigned: Harsh panchal » Unassigned

@arunkumark
I have check this issue and providing a new patch.as soon as possible. Thanks

Harsh panchal’s picture

Harsh panchal commented
Status: Needs work » Needs review
StatusFileSize
new phpcs-drupal-coding-standard-new-3294887-5.patch7.47 KB

Applying a new patch #5.

jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40
Status: Needs review » Active

I will review this patch.

jatingupta40’s picture

jatingupta40 commented
Assigned: jatingupta40 » Unassigned
Status: Active » Needs work

The given patch is working fine.
Just showing me one warning regarding routing file permission.

FILE: /var/www/html/drupalopensource/web/modules/contrib/content_hub_tree/content_hub_tree.routing.yml
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user
| | can change something - rather than "access administration pages" which is about viewing but not changing
| | configurations.
--------------------------------------------------------------------------------------------------------------------------------

mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new phpcs-drupal-coding-standard-new-3294887-8.patch7.87 KB
new interdiff_5-8.txt334 bytes

Updated patch #5 by addressing #7, please review it.

meeni_dhobale’s picture

meeni_dhobale commented

@mrinalini9 your patch is working fine but it showing me a single warning as

FILE: ...odules/contrib/content_hub_tree/src/Form/MenuContentTreeForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
212 | WARNING | \Drupal calls should be avoided in classes, use
| dependency injection instead
----------------------------------------------------------------------

If you try to use dependency injection you can solve this warning as well.

meeni_dhobale’s picture

meeni_dhobale commented
Status: Needs review » Needs work
jatingupta40’s picture

jatingupta40 commented

@Meeni_Dhobale the warning you are facing, for that the different issue has already been created and is in work there.
You can see this. https://www.drupal.org/project/content_hub_tree/issues/3294909
Thanks

meeni_dhobale’s picture

meeni_dhobale commented

@JatinGupta40 Thank you inform.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs work » Needs review

As per the comment #11 keeping the status Needs review.

sharayurajput’s picture

sharayurajput commented

I will review this

sharayurajput’s picture

sharayurajput commented

I reviewed this patch applied successfully & cleanly. The patch looks good and working properly.

sharayurajput’s picture

sharayurajput commented
Status: Needs review » Reviewed & tested by the community
sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput
Status: Reviewed & tested by the community » Needs review

Will review this patch

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Reviewed & tested by the community

reviewed this patch applied successfully & cleanly. The patch looks good and working properly.

oleh.tarasiuk’s picture

oleh.tarasiuk commented
Status: Reviewed & tested by the community » Fixed
oleh.tarasiuk’s picture

oleh.tarasiuk commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.