Problem/Motivation

This module is pointless if a user cannot add a note & without the "Add Note" link displaying, there's no way to add a note.

Steps to reproduce

  1. Enable the module
  2. Add the "create moderation notes" permission to a role on the user that you wish to create a note with.
  3. Edit a node & leave in draft mode
  4. Highlight some text in the body
  5. A link that says "Add Note" should display above the highlighted text

Proposed resolution

The issue seems to be related to the JS code in the `moderation_note.js` file that displays the link. This module was last updated in May 2020, a very long time ago. So there probably has been jQuery updates or browser JS changes that don't agree with the script anymore. This happened with another module that just needed tweaks to work with newer standards.

Remaining tasks

  1. Update the `moderation_note.js` file

Comments

mcannon created an issue. See original summary.

samuel.mortenson’s picture

Priority: Critical » Normal
StatusFileSize
new380 bytes

@mcannon I don't think this is JS related. What theme are you using? The standard profile switched its theme recently which renders in a way that puts the node content on top of the tooltip. The attached patch fixes that, but want to check first that this is what you were seeing.

emilymathew’s picture

StatusFileSize
new446.59 KB
new483.3 KB

I was facing the same issue. Thanks for the patch in #2. It is working, I have tested it with theme Olivero 9.4.3.

I was using this module and it was working perfectly fine with default theme Bartik in Drupal 9.3 version. But when I upgrade to Drupal 9.4, the default theme changed to Olivero and it was not working. But if I switch the theme to Bartik, then it will work.

Now the patch in #2 is working fine with new theme Olivero in Drupal 9.4.3.

jdearie’s picture

I was testing this module on a vanilla 9.4.3 site on Pantheon's free hosting setup. The Add note does not appear when using Olivero, but when using Bartik, the text does appear. I was trying to figure out how to add a note when I found this issue. I love the functionality of this module and will need to test with my real site / theme.

emilymathew’s picture

Status: Active » Reviewed & tested by the community

I missed to update the status after testing and updating in #3.

The patch in #2 works fine with Olivero theme.

  • d73258d committed on 8.x-1.x
    Issue #3294838 by samuel.mortenson, emilymathew, mcannon, jdearie: "Add...
samuel.mortenson’s picture

Status: Reviewed & tested by the community » Fixed
samuel.mortenson’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.