* warning: array_fill(): Number of elements must be positive in /includes/database.inc on line 241.
* warning: implode(): Invalid arguments passed in /includes/database.inc on line 241.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1 query:
DELETE FROM locales_target
WHERE language IN ('hu')
AND lid IN (SELECT lid FROM locales_source WHERE textgroup IN ())
in l10n_client/l10n_client.module on line 466.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | textgroup-warning.patch | 1.61 KB | gábor hojtsy |
| #10 | l10n_client-port-361147.patch | 1005 bytes | dawehner |
| #9 | array_fill_issue.patch | 1.56 KB | gábor hojtsy |
Comments
Comment #1
gábor hojtsyLooks like our new textgroup selector does not actually enforce you to select at least one textgroup. What happens if you do select a textgroup? (It should work without errors :)
Comment #2
hass commentedEDIT: removed stupid comment
Comment #3
hass commentedEDIT: removed stupid comment
Comment #4
hass commentedThe checkbox(es) should not be "required"...
Comment #5
gábor hojtsyWell, at least one textgroup should be chosen, right?
Comment #6
hass commentedNot really. If you don't like to clean you DB you need to deselect all. Otherwise people will loose "views" translation as one example or they loose their custom translations...
Comment #7
gábor hojtsyOh, sure, then we should have code to check whether something was selected at all and only run the DELETE in that case. This code seems to be broken nevertheless.
Comment #8
hass commentedIf we are on it we should also add the two "Mode" radios we also have on "admin/build/translate/import"
Comment #9
gábor hojtsyOk, here is a quick patch to fix this error, committing to D6. Should be ported to D7 as well.
Comment #10
dawehnerThis is based on the other ported patch.
Comment #11
gábor hojtsyWe should not attempt build the $lids list either, if there are no textgroups. That's part of the ported version of the nested query in D7. So committed this attached patch. Thanks!