The connector should allow signing HTTP requests to Amazon OpenSearch Service.

Issue fork search_api_opensearch-3294653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

osopolar created an issue. See original summary.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Issue summary: View changes

osopolar opened merge request !12

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs work

Thanks for the feature request. Looks great!

As this module brings in new composer dependencies, I would suggest it be a separate sub-module, and do a requirements check for the required php library.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

Thanks for the hint. I missed the new composer dependencies. I will create the sub-module soon.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

This was added to the latest version of the opensearch-project/opensearch-php lib: https://github.com/opensearch-project/opensearch-php/pull/63

sassafrass’s picture

sassafrass commented

I would like to use this feature and was wondering what the latest status was?

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

There is no new status other than what you see in the comments.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Issue tags: +Needs issue summary update

Tagging 'Needs issue summary update'. We should add the remaining tasks there.

osopolar opened merge request !35

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

To clarify: I just needed to fix my old implementation (MR !12), but the sub-module approach (MR !35) is the way to go.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Keeping my eye on this. Let me know when it's ready for review.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Status: Needs work » Needs review

Merge request !35 is ready for review 😇.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Needs work

Had a quick look.

  • We need to add aws sdk as a suggest to the composer.json
  • We need to add a requirements check for the sdk in the sub-module .install file

Have a look at how search_api_opensearch_location does it.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

@kim.pepper:

  • I added aws/aws-sdk-php to composer suggests.
  • The requirements check for the sdk in the sub-module .install file is there:
    if (!class_exists(Credentials::class)) { ...

kim.pepper closed merge request !12

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Fixed

Merged to 2.x and 3.x. Thanks!

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

Today I wanted to implement the feedback and found that everything was already done. Thank you kim.pepper for the finishing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.