Postponed on #3202462: [PP-1] Provide option for contrib modules to map their D6 / D7 field formatter and widget plugin IDs to the equivalent D9 plugin ID
which is postponed on #3204212: Convert remaining widget and formatter type migrations to MigrateField plugins
See Change Record DRAFT: https://www.drupal.org/node/3208917
Problem/Motivation
Inline Entity Form can be used for multiple field types. The widget settings are not correctly migrated for all of them. Ensure that they are migrated correctly for the following field types:
entityreferencecommerce_line_item_referencecommerce_product_reference
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff_2-3.txt | 1.09 KB | immaculatexavier |
| #3 | 3294481-3.patch | 1.5 KB | immaculatexavier |
| #2 | 3294481-inline_entity_form-2.patch | 1.58 KB | omkar.podey |
Comments
Comment #2
omkar.podey commentedinitial patch, additional check in MigrationHelper, adding hook_field_migration_field_widget_info().
Comment #3
immaculatexavier commentedAttached patch against #2
Comment #4
geek-merlinSorry folks. There is already too many similar issues and patches out there.
Please never open issues without researching what's there already.
There's no issue summary either.
Adding this issue contributes to chaos, unnecessary work for others, adds bad karma, and negative contribution points.
Please do the clean up work.
Comment #5
wim leersDone.
Comment #6
geek-merlinThanks Wim for chiming in and clarifying... partially.
> There is already too many similar issues and patches out there.
> Please never open issues without researching what's there already.
See parent issue.
Comment #7
anybodyPlease note that the patch posted in #3 overlaps with the patches posted here: #3213595: MigrationHelper::alterPlugins assumes settings isn't already an array
But #3 in this issue additionally contains:
which seems to be the key point here.
Did anyone review or test this already? Any suggestions in which of the issues to proceed?
Comment #8
anybody!! Important information !!
(would have been nice if the patch authored had mentioned this .......)
All patches here in #2 and #3 are based on #3202462: [PP-1] Provide option for contrib modules to map their D6 / D7 field formatter and widget plugin IDs to the equivalent D9 plugin ID (CR DRAFT: https://www.drupal.org/node/3208917) which has not been committed yet. It's also postponed on #3204212: Convert remaining widget and formatter type migrations to MigrateField plugins !
This is why nothing will happen without also applying the core patches. So we should postpone this on these issues.
Furthermore, this will need work once the parent issue with the other changes is committed, for example this line is wrong:
the above line has to be removed, but as this is also part of the parent / sibling issue, the future patch should ONLY contain the relevant changes here, which means the new hook implementation!
Comment #9
anybodyComment #10
geek-merlinThanks for the great cleanup work!
Comment #11
anybody